41 bug bucketsdepositwork return ids=true does not return ids when sp…

…ecified (#42)

* refactor(cli/schedules.py): separating schedules functions from pipelines

Schedules client created to handle all operations related to schedules

* feat(cli): improvements to pipelines and schedules commands

* refactor(schedules.py): adding section when using details option

* feat(variables.py): adding missing statuses

* feat(cli): adding configs commands

confgis commands added so the cli can work with the new version of pipelines(^2.7.0)

* refactor(http/configs.py): removing print statement

* feat(cli/schedules.py): fixing bad formatting

* fix(cli): addressing comments on PR

* feat(cli): adding configs commands

confgis commands added so the cli can work with the new version of pipelines(^2.7.0)

* refactor(http/configs.py): removing print statement

* feat(cli/schedules.py): fixing bad formatting

* fix(cli): addressing comments on PR

* test(test_http_context.py): adding tests

Tests added for pipelines client on HTTPContext.

* ci(ci.yml): adding steps to tests job

Adding steps for: starting docker services needed for tests; setting development workspace and killing services after tests are completed.

* ci(ci.yml): changing docker-compose file name

* ci(ci.yml): adding docker login step

* feat(cli): adding configs commands

confgis commands added so the cli can work with the new version of pipelines(^2.7.0)

* refactor(http/configs.py): removing print statement

* feat(cli/schedules.py): fixing bad formatting

* fix(cli): addressing comments on PR

* feat(cli): improvements to pipelines and schedules commands

* fix(cli): addressing comments on PR

* test(test_http_context.py): adding tests

Tests added for pipelines client on HTTPContext.

* ci(ci.yml): adding steps to tests job

Adding steps for: starting docker services needed for tests; setting development workspace and killing services after tests are completed.

* ci(ci.yml): changing docker-compose file name

* ci(ci.yml): adding docker login step

* fix(workflow/utils/read.py): changing active workspace filename

* fix(cli/schedules.py): fixing variable name

* feat(workflow-dev): added workspace configuration for live system tests

* fix(http): fixed pipelines,schedules and configs to use baseurls with prefixing versioning

* fix(workspace-configs): updated workspace configs to point to v2

* refactor(test_http_context.py): fixing tests

* refactor(workspaces/development.yml): adding version suffix to baseurls

* Retrying

* fix(docker-compose-tutorial.yml): settings services to latests version

* fix(docker-compose-tutorial.yml): adding local service

* fix(http/buckets.py): fixed deposit function

deposit() function was not using the "return_ids" argument and always returning True, fixed. Tests passing.

* Retrying

---------

Co-authored-by: Shiny Brar  (he/il) <[email protected]>

workflow/http/buckets.py

@@ -1,6 +1,7 @@
 """Workflow Buckets API."""
 
 from typing import Any, Dict, List, Optional, Union
+from urllib.parse import urlencode
 
 from requests.models import Response
 from rich.console import Console
@@ -54,10 +55,10 @@ def deposit(
         >>> buckets.deposit([work.payload], return_ids=True)
         ["5f9b5e1b7e5c4b5eb1b""]
         """
-        params: Dict[str, Any] = {}
+        params: Dict[str, Any] = {"return_ids": return_ids}
         with self.session as session:
             response: Response = session.post(
-                url=f"{self.baseurl}/work",
+                url=f"{self.baseurl}/work?{urlencode(params)}",
                 json=works,
                 params=params,
                 timeout=self.timeout,