Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Archive Functionality #13

Merged
merged 21 commits into from
Jan 28, 2024
Merged

Refactor: Archive Functionality #13

merged 21 commits into from
Jan 28, 2024

Conversation

tjzegmott
Copy link
Contributor

Summary

This PR introduces configuration from the Workspace Config for the Archive modules of Workflow. Additionally, the methods of archiving have been broken down into separate modules for each of the transfer protocols avaiable.

Commits

  • refactor(config-definition): remove upload from archive
  • feat(workspace): define examples of the config archive yaml entries
  • refactor(lifecycle-archive): respect archive methods set as available in workspace
  • refactor(lifecycle-archive): add placeholder for http methods

@tjzegmott tjzegmott linked an issue Jan 16, 2024 that may be closed by this pull request
Archive Functionality #9
Closed
12 tasks
@tjzegmott tjzegmott marked this pull request as ready for review January 18, 2024 16:41
@tjzegmott tjzegmott marked this pull request as draft January 18, 2024 19:09
@tjzegmott tjzegmott marked this pull request as ready for review January 18, 2024 19:10
@tjzegmott
ci(gh-action): ci on pr sync
ed2677c 
Signed-off-by: Tarik Zegmott <[email protected]>
@tjzegmott
feat(utils): new function to add loki handler to logger
a0d2463 
linting

Signed-off-by: Tarik Zegmott <[email protected]>
@tjzegmott
ci(gh-action): ci python version bumped to 3 10
2143ca3 
reason: workflow/definitions/work.py:137: error: X
Y syntax for unions requires Python 3.10

Signed-off-by: Tarik Zegmott <[email protected]>
@tjzegmott
build(pyproject): add logging-loki dep
faf5036 
Signed-off-by: Tarik Zegmott <[email protected]>
@tjzegmott
test(pytest): set up requisit initial config
7cfcc4d
shinybrar
shinybrar requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@shinybrar shinybrar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add a docs file for Minio Setup and also in that tell the admin user, that you have to setup the permissions for the S3 Storage bucket properly.
  • Create a workspace config doc and document all the permutations of the archive config

tests/test_archive.py Outdated Show resolved Hide resolved
workflow/lifecycle/archive/__init__.py Show resolved Hide resolved
workflow/lifecycle/archive/__init__.py Show resolved Hide resolved
workflow/lifecycle/archive/posix.py Outdated Show resolved Hide resolved
workflow/workspaces/chimefrb.yml Show resolved Hide resolved
shinybrar
shinybrar requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@shinybrar shinybrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somes changes are needed.

@shinybrar shinybrar merged commit 319e644 into main Jan 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinybrar shinybrar shinybrar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Archive Functionality
2 participants
@tjzegmott @shinybrar