Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): multiple buckets + runspace #47

Merged
merged 6 commits into from
Jun 6, 2024
Merged

feat(cli): multiple buckets + runspace #47

merged 6 commits into from
Jun 6, 2024

Conversation

shinybrar
Copy link
Contributor

@shinybrar shinybrar commented Jun 6, 2024 •
edited
Loading

Linked Issues: #45 #46
Add the following feature

  • You can now fetch work from multiple buckets at once via,
workflow run --site=chime A B C
  • Additionally you can now provide the workspace config as a runtime configuration,
workflow run --runspace '{"baseurls": {"buckets": "http:/get.sh"}}'

@shinybrar
feat(cli): workflow run command now accepts multiple arguments for bu…
7633323 
…ckets and also supports a runspace argument to overload workspace configuration
@shinybrar shinybrar linked an issue Jun 6, 2024 that may be closed by this pull request
[FEAT] Support multiple buckets #46
Closed
@shinybrar shinybrar self-assigned this Jun 6, 2024
odarotto
odarotto reviewed Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@odarotto odarotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shinybrar shinybrar merged commit 817e125 into main Jun 6, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odarotto odarotto odarotto left review comments

@chrisfandrade16 chrisfandrade16 Awaiting requested review from chrisfandrade16

Assignees

@shinybrar shinybrar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Support multiple buckets
2 participants
@shinybrar @odarotto