Update REDCapR to 1.2.0, update guess_max to Inf #202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a backlog issue that can now be fixed with the release of REDCapR 1.2.0.
In short, there was an assertion in the REDCapR code that failed on supplying
Inf
toguess_max
, which we want to have as the default when guessing column types with thereadr
package. It would result in this error from our UI:Now that REDCapR is updated, we can use
Inf
as the default.Proposed Changes
List changes below in bullet format:
.Machine$integer.max
forInf
as the default value forguess_max
inread_redcap()
renv
lockfile to use REDCapR 1.2.0Issue Addressed
Closes #145
PR Checklist
Before submitting this PR, please check and verify below that the submission meets the below criteria:
guess_max
value if it still wasn't working.RDS
) updated underinst/testdata/create_test_data.R
usethis::use_version()
Code Review
This section to be used by the reviewer and developers during Code Review after PR submission
Code Review Checklist