-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(master): add .desktop file for use with Flatpak #122
Conversation
.desktop
file for use with Flatpak.desktop
file for use with Flatpak
.desktop
file for use with Flatpak.desktop
file for use with Flatpak
.desktop
file for use with Flatpak
wouldn't it just be better to add the flatpak manifest here and update the release pipeline so this repo creates and publishes it? |
Yeah, that would work fine I think. Would you like me to make a PR with manifest, or add it to this one? |
👍🏻 on it. i think this pr can stay in flight, although check in with @CHollingworth about any icons to reference in the desktop file? |
any of the logo variants would work nicely https://github.com/CHollingworth/Lampray/tree/master/logo |
Yeah. I was just going to copy those to /app/share/icons when building. |
@airtonix To clarify, would you like me to submit a PR with the manifest? |
@poperigby Feel free to contribute to #123. if you can, otherwise use the question about the pr title here (since it has impact on the generated changelog and resulting release version:
I think My understanding of the scope part, that it should help describe what part of the project (the component) this change affects. is that right? |
Sure!
Oops, sorry. I was just following what the other PRs were named like for the scope. I'm not super familiar with how conventional commits work either. |
Don't apologise. I thought there was something you knew that I didn't. |
@poperigby but in terms of next steps, i think update the desktop file to accurately point at the logo. for now it might be safe to assume that this one singular desktop file is only used for the flatpak distro. In future i can imagine that there might be other forms of packaging. |
Do you mean just putting |
I'm working on a Flatpak for Lampray at https://github.com/poperigby/io.github.chollingworth.Lampray, and it would be nice to have a
.desktop
file for better system integration.