feat: changed directory for where data is stored to be fixed (+ some code fixes) #164
Conversation
SleepySpaceBear
changed the title
SleepySpaceBear
changed the title
|
I think I have it where I want to be with respect to some code fixes + the change to the working directory. I'll have another PR branching off from this with some changes to how the bit7zip dependency is set up. |
Lampray/Control/lampConfig.h
Outdated
|
|
||
| //((std::string)std::getenv("HOME")) + "/.lamp/ | ||
| const lampString baseDataPath = "Lamp_Data/"; | ||
| const lampString baseDataPath = lampString(std::getenv("HOME")) + "/.lampray/"; |
There was a problem hiding this comment.
For reference, the placement of files was @CHollingworth's preference (see ##92). Assuming he considers this PR, you may have some difficulties getting it merged with this change.
There was a problem hiding this comment.
At this point, with how inactive this repo is, I might just focus on maintaining my fork
There was a problem hiding this comment.
The Baldur's Gate 3 implementation was broken, and I'm working on fixing it. There's a lot of other weird stuff with its current state as well that I've been working on fixing
There was a problem hiding this comment.
That is fair. If you have any interest in my changes on #147 feel free to either steal them, or let me know what you might want and I can try to get it rebased or altered for you to pull in.
I don't think I have made much of any other changes that you would really want or need.
There was a problem hiding this comment.
Disclaimer that I'm using arch and haven't tested on other systems.
I was able to fix the issues with using bit7z by just setting up my fork to track the latest tagged version of bit7z since there seems to have been breaking changes with 7zip at some point between bit7z 4.0.0-rc and the latest version. Of course .unrar support would be nice.
Right now I got the overlay filesystem implementation working with Baldur's Gate. I need to figure out why the mods aren't being installed properly though. I think I'm missing the overlay set up for the player profile stuff.
I want to also implement a checker for whether the current mod setting is deployed rather than just always having the deployed button. I think also having it configurable as to whether overlayfs is used or just overwriting the game files would be nice. I do have to fix some stuff with respect to overlayfs since it's very easy for it to get into a state where I have to manually it.
|
Going to change it to use the XDG spec for the default directory and make it using the PWD as an option to be set in cmake |
|
@CHollingworth This should be ready for merging now |
|
On a fresh build the applicaion crashes on startup with the following error: [LAMP:LOG:0] Loading LAMP CONFIG:LanguagePath |
|
Ill add it to the test 2.0.0 |
This initially was supposed to be just be changing where the directory for data is stored to be fixed, but "Libary" and a header with a space in it inflicted psychic damage on me.
I'm now working on fixing a crash when trying to deploy my mods in Baldur's Gate 3. It has something to do with 7zip now. Earlier, it was a throw from the missing overlay directory for the app data stuff (see b5c862e for the fix).