Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project 1: Matt Schwartz #19

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mzschwartz5
Copy link

Features implemented:

  • Naive (brute-force) algorithm
  • Uniform scattered grid
  • Coherent uniform grid
  • Bonus: grid-looping optimization

Note: I implemented the grid-looping optimization before realizing it was extra, so I wasn't able to test the 8 vs. 27 grid cell check approach. That said, the grid-looping optimization I implemented does a distance check to omit neighboring cells that are too far away, so to some extent, my cell-width testing also answered these questions implicitly.

Feedback:

  • Figures in instructions are impossible to read in github dark mode (my eyes!)
  • The TODO comments in the code are a bit ambiguous for my taste. Often, I felt that I knew what to do after reading the instructions, only to be thoroughly by the code comments. After some head scratching, it turned out my intuition was correct from the start.
  • Definitely could have used a demo on using NVIDIA NSight debugging + profiling tools before starting this. I relied on homemade methods instead, which I'm sure are far worse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant