Skip to content
This repository has been archived by the owner on Aug 13, 2020. It is now read-only.

Refactor handler method matchers into separate classes #316

Closed
wants to merge 1 commit into from

Conversation

purple52
Copy link
Contributor

@purple52 purple52 commented Feb 3, 2017

Closes #327.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 90.055% when pulling e7171c9 on rng-json-matcher into 11ae967 on master.

Copy link
Contributor

@mapingo mapingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a change log entry for these changes?

}

@Override
protected boolean matchesSafely(Class<?> handlerClass, Description description) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing finals

}

@Override
public void describeTo(Description description) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final description

}

@Override
public void describeTo(Description description) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final

}

@Override
public void describeTo(Description description) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final

}

@Override
protected boolean matchesSafely(Class<?> handlerClass, Description description) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finals

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 90.055% when pulling 071c0d5 on rng-json-matcher into 11ae967 on master.

@purple52 purple52 added this to the 1.5.0 milestone Feb 20, 2017
@purple52 purple52 modified the milestones: 2.0.0, 1.5.0 Mar 30, 2017
@purple52 purple52 modified the milestones: 2.1.0, 2.0.0 Jun 16, 2017
@purple52 purple52 removed this from the 2.1.0 milestone Nov 28, 2017
@mapingo mapingo closed this Mar 4, 2019
@mapingo mapingo deleted the rng-json-matcher branch March 4, 2019 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants