update macros for codecvt and support C++26 support on clang19 #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
commented
Jan 6, 2025
| @@ -1520,6 +1520,7 @@ static_assert(CLI::detail::is_tuple_like<std::array<int, 10>>::value, "std::arra | |||
| static_assert(!CLI::detail::is_tuple_like<std::string>::value, "std::string should not be like a tuple"); | |||
| static_assert(!CLI::detail::is_tuple_like<double>::value, "double should not be like a tuple"); | |||
| static_assert(CLI::detail::is_tuple_like<std::tuple<double, int, double>>::value, "tuple should look like a tuple"); | |||
| static_assert(!CLI::detail::is_tuple_like<std::complex<double>>::value, "std::complex should not be like a tuple"); | |||
Comment on lines
+298
to
+300
| // Even though in C++26 std::complex gains a std::tuple interface, for our purposes we treat is as NOT a tuple | ||
| template <typename S> class is_tuple_like { | ||
| template <typename SS> | ||
| template <typename SS, enable_if_t<!is_complex<SS>::value, detail::enabler> = detail::dummy> |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1113 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 17 17
Lines 4546 5034 +488
Branches 0 1029 +1029
===========================================
+ Hits 4546 5034 +488 ☔ View full report in Codecov by Sentry. |
phlptp
approved these changes
Jan 7, 2025
|
@henryiii I am going to merge this and close the other one tomorrow unless you have other thoughts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit you care about is 9a2884a @phlptp
where I fix the build error on LLVM 19 with C++26 after rooting the actual template issue (see #1098 (comment))
It comes down to C++26 adding a tuple interface to std::complex https://en.cppreference.com/w/cpp/numeric/complex/tuple_size