Skip to content

Develop #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Develop #55

wants to merge 6 commits into from

Conversation

naderzare
Copy link
Member

No description provided.

@naderzare naderzare requested a review from SK2iP December 31, 2024 15:53
SK2iP
SK2iP approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@SK2iP SK2iP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Tnx nader.

Just for my clarity why did you add rpc_timeout to thrift_client argument ? is it just for well-structured and maintains clarity of the project ?

@SK2iP
Copy link
Member

SK2iP commented Jan 2, 2025

Additionally wouldn't be beneficial to use set_timeout function, to specify how long the client should wait for server answer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SK2iP SK2iP SK2iP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naderzare @SK2iP