-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AB2D-6124] Add Opt Out Metrics to Slack Message #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rwolfe-Nava
changed the title
[WIP][AB2D-6124] Add Opt Out Metrics to Slack Message
[WIP] [AB2D-6124] Add Opt Out Metrics to Slack Message
Jun 10, 2024
coilysiren
reviewed
Jun 10, 2024
smirnovaae
requested changes
Jun 10, 2024
Rwolfe-Nava
commented
Jun 11, 2024
optout/src/test/java/gov/cms/ab2d/optout/OptOutProcessorTest.java
Outdated
Show resolved
Hide resolved
smirnovaae
reviewed
Jun 11, 2024
optout/src/test/java/gov/cms/ab2d/optout/OptOutProcessorTest.java
Outdated
Show resolved
Hide resolved
Rwolfe-Nava
changed the title
[WIP] [AB2D-6124] Add Opt Out Metrics to Slack Message
[AB2D-6124] Add Opt Out Metrics to Slack Message
Jun 11, 2024
smirnovaae
approved these changes
Jun 11, 2024
smirnovaae
reviewed
Jun 17, 2024
smirnovaae
reviewed
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/AB2D-6124
🛠 Changes
Add more information to the lambda completion slack message with metrics about processed opt out information.
ℹ️ Context for reviewers
I want to make sure my approach here is good. I wanted to avoid going to the database multiple times for performance reasons.
✅ Acceptance Validation
Tested on IMPL environment:
🔒 Security Implications
If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.