Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ab2d-5997/parse sqs message #90

Merged
merged 16 commits into from
Mar 11, 2024
Merged

Ab2d-5997/parse sqs message #90

merged 16 commits into from
Mar 11, 2024

Conversation

smirnovaae
Copy link
Contributor

@smirnovaae smirnovaae commented Mar 8, 2024

🎫 Ticket

https://jira.cms.gov/browse/AB2D-5997

🛠 Changes

  • Get bfd bucket name and response file name from SQS message for OptOut Lambda
  • Get bfd bucket name and upload path from environmental variables for Attribution LAmbda

ℹ️ Context for reviewers

(Background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers.)

✅ Acceptance Validation

  • Updated unit tests.
  • Tested manually on impl environment.

From logs:
2024-03-08T16:16:06.111-08:00 Buket name: bfd-test-eft
2024-03-08T16:16:06.111-08:00 File name: bfdeft01/ab2d/in/test-8210558783.txt

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

…essage

# Conflicts:
#	attribution-data-file-share/src/main/java/gov/cms/ab2d/attributionDataShare/AttributionDataShareConstants.java
#	attribution-data-file-share/src/main/java/gov/cms/ab2d/attributionDataShare/AttributionDataShareHandler.java
#	optout/src/main/java/gov/cms/ab2d/optout/OptOutConstants.java
#	optout/src/main/java/gov/cms/ab2d/optout/OptOutProcessor.java
#	optout/src/main/java/gov/cms/ab2d/optout/OptOutS3.java
#	optout/src/test/java/gov/cms/ab2d/optout/OptOutProcessorTest.java
@smirnovaae smirnovaae merged commit 27453dc into main Mar 11, 2024
3 of 4 checks passed
@smirnovaae smirnovaae deleted the AB2D-5997/Parse_sqs_message branch March 11, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants