Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ab2d-6020/Assume Role for Lambda Import/Export #91

Merged
merged 11 commits into from
Mar 13, 2024
Merged

Conversation

smirnovaae
Copy link
Contributor

@smirnovaae smirnovaae commented Mar 13, 2024

🎫 Ticket

https://jira.cms.gov/browse/AB2D-6020

🛠 Changes

For both lambdas:

  • Added ability to get values from Parameter store
  • Added Assume role credentials
  • Changed connection to database
  • Removed .OUT from file name

ℹ️ Context for reviewers

(Background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers.)

✅ Acceptance Validation

Tested manually on impl environment.
Lambdas are able to connect to database and read file from bfd test s3

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

@smirnovaae smirnovaae changed the title Ab2 d/assume role Ab2d-6020/Assume Role for Lambda Import/Export Mar 13, 2024
@smirnovaae smirnovaae merged commit c4d4233 into main Mar 13, 2024
3 of 6 checks passed
@smirnovaae smirnovaae deleted the AB2D/Assume_role branch March 13, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants