Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lambda handler paths #959

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Fix lambda handler paths #959

merged 3 commits into from
Jun 21, 2024

Conversation

kyeah
Copy link
Contributor

@kyeah kyeah commented Jun 21, 2024

🎫 Ticket

N/A

🛠 Changes

  • Remove /bin/ directories from function zips using zip -j
  • Rename files to bootstrap

ℹ️ Context

Was looking at the lambda logs and saw some errors with trying to find the entrypoint. After reading the AWS documentation, I realized that it expects the zip file to have exactly one binary, which is specifically named bootstrap 😅

This was an oversight on my part — I thought if the handler was specified as cclf-import in the lambda config, it would look for that binary filename instead.

🧪 Validation

Verified in logs (doesn't complete successfully, we have another network issue to address..)

CleanShot 2024-06-21 at 13 35 58@2x

Copy link
Contributor

@austincanada austincanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Kevin for the fix!

@kyeah kyeah merged commit fabde15 into main Jun 21, 2024
10 checks passed
@kyeah kyeah deleted the kev/rm-zip-nested-folder branch June 21, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants