BCDA-7416: Remove duplicate logging

[karinamzalez]

🎫 Ticket

https://jira.cms.gov/browse/BCDA-7416

🛠 Changes

(What was added, updated, or removed in this PR.)

• removes duplicate logging in api.go
• adds comments for future refactors that would improve logging

ℹ️ Context for reviewers

(Background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers.)

• in service/main/main.go > listIPs() : replace panic with ssas.Logger.Fatal
• in server.go > NewServer > ln 164: add return statement after error is logged, so more generic log outside of this condition doesn't log error again.
• in public/api.go: refactor error logging in ValidateSecret.
• Adds three "TODOs" to bring attention to potential areas for refactor to streamline logging. TODOs are for the following:
  • Remove logging from JSONError and assert that 130 use cases of this function still have, more specific, logging outside of function
  • Remove OperationFailed and refactor use cases to use ssas.Logger
  • Refactor ChooseSigningKey so error logging happens outside of function

✅ Acceptance Validation

(How were the changes verified? Did you fully test the acceptance criteria in the ticket? Provide reproducible testing instructions and screenshots if applicable.)

🔒 Security Implications

• This PR adds a new software dependency or dependencies.
• This PR modifies or invalidates one or more of our security controls.
• This PR stores or transmits data that was not stored or transmitted before.
• This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

[laurenkrugen-navapbc]

This looks good overall, just need a couple things:

1. looks like tests are failing. are the unit-tests updated to reflect the changes?
2. can we also please update the PR title to be in the format of BCDA-XXXX: <...>?

[laurenkrugen-navapbc]

looks good, thanks for updating! 😃