BCDA-7529: Remove nonsensitive env variables from ops repos #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@StewGoin this adds a new software dependency, github.com/joho/godotenv, to read .env files containing only non-sensitive values. |
alex-dzeda
requested review from
StewGoin,
kyeah,
karinamzalez and
laurenkrugen-navapbc
kyeah
approved these changes
Jan 11, 2024
| @@ -34,7 +34,7 @@ go clean | |||
| echo "Building ssas..." | |||
| go build -ldflags "-X github.com/CMSgov/bcda-ssas-app/ssas/constants.Version=$VERSION" -o ssas ./service/main | |||
| echo "Packaging ssas binary into RPM..." | |||
| fpm -v $VERSION -s dir -t rpm -n ssas ssas=/usr/local/bin/ssas swaggerui=/etc/sv/ssas | |||
| fpm -v $VERSION -s dir -t rpm -n ssas ssas=/usr/local/bin/ssas swaggerui=/etc/sv/ssas cfg/configs/=/go/src/github.com/CMSgov/bcda-ssas-app/ssas/cfg/configs/ | |||
There was a problem hiding this comment.
good catch on this one!
laurenkrugen-navapbc
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-7529
🛠 Changes
Re-configured pulling of variables from environment, so that a volume is attached to docker with the configs. Removal from S3 will be a separate manual process.
ℹ️ Context for reviewers
This assumes that DEPLOYMENT_TARGET is set in all environments.
The non-sensitive values to be pulled in through env files are:
DEBUG
DEPLOYMENT_TARGET (duplicated for reference within a file).
SSAS_DEFAULT_SYSTEM_SCOPE
SSAS_IDLE_TIMEOUT
SSAS_LOG
SSAS_READ_TIMEOUT
SSAS_WRITE_TIMEOUT
✅ Acceptance Validation
Unit-tests pass, and a dev deployment / re-deploy with the S3 variables for the variables listed above works.
🔒 Security Implications
If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.