Skip to content

Commit

Permalink
[WNMGDS-1693] Remove banner role from Dialog (#2062)
Browse files Browse the repository at this point in the history
Remove banner role from Dialog.
  • Loading branch information
zarahzachz authored and pwolfert committed Aug 29, 2022
1 parent f1b6864 commit 3e5cdd0
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion packages/design-system/src/components/Dialog/Dialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ export const Dialog = (props: DialogProps) => {
{...modalProps}
>
<div role="document">
<header className={headerClassNames} role="banner">
<header className={headerClassNames}>
{
// TODO: make heading required after removing title
(title || heading) && (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ exports[`Dialog close button text and variation can be changed 1`] = `
>
<header
class="ds-c-dialog__header"
role="banner"
>
<h1
class="ds-h2"
Expand Down Expand Up @@ -54,7 +53,6 @@ exports[`Dialog renders with additional classNames and size 1`] = `
>
<header
class="ds-c-dialog__header test-header"
role="banner"
>
<h1
class="ds-h2"
Expand Down

0 comments on commit 3e5cdd0

Please sign in to comment.