-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPC-4259] Add lambda for syncing ip address set #2269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashley-weaver
had a problem deploying
to
test
September 17, 2024 21:03
— with
GitHub Actions
Failure
ashley-weaver
had a problem deploying
to
test
September 18, 2024 12:12
— with
GitHub Actions
Failure
ashley-weaver
had a problem deploying
to
test
September 18, 2024 12:18
— with
GitHub Actions
Failure
ashley-weaver
had a problem deploying
to
test
September 18, 2024 14:14
— with
GitHub Actions
Failure
ashley-weaver
had a problem deploying
to
test
September 18, 2024 16:08
— with
GitHub Actions
Failure
ashley-weaver
had a problem deploying
to
test
September 18, 2024 16:32
— with
GitHub Actions
Failure
ashley-weaver
had a problem deploying
to
test
September 18, 2024 16:44
— with
GitHub Actions
Failure
ashley-weaver
had a problem deploying
to
test
September 18, 2024 16:45
— with
GitHub Actions
Failure
MEspositoE14s
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two quick points but otherwise looks good to me.
- Can we add a read me or something that tells people they have to setup credentials from CloudTamer before they can run
make test
locally? - Definitely outside the scope of this ticket, but we should consider another ticket to create a shared library so we don't have duplicate code in all three of our lambdas. The stuff we use to connect to AWS, get secrets and connect to the DB is repeated in all of them.
Agreed on pulling the AWS/DB out into a common directory; I tried to make this work, but I wasn't able to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-4259
🛠 Changes
Adds lamdba to keep IP sets in sync on AWS.
ℹ️ Context
By default, the production DPC API is not open to the public network. Organizations must provide IP addresses for inclusion in DPC's network allowlist so that they can access the DPC API.
We are currently storing these IP addresses in the database, but they are not automatically synced to the AWS WAF IP Set for functional purposes.
🧪 Validation
main_test.go includes an integration test that updates the WAF set, verifies the update, and then resets it.