Tech Debt - Update Dependencies #2329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignore to ignore all contents in project tmp/ directory, but to create an empty directory (with .keep placeholder) to support local, cicd, and op tmp work as necessary.
…ugin. Preserving commit history on files by minimizing changes during rename.
…ation-tests profile
…than reusing Surefire (generally used to unit test)
…support for verbose test reporting when desired
…smoketest is cleaned, compiled, and packaged during dpc-test.sh anyways, and recent updates to CICD/github action runner seem to have introduced new problems with our process
…dModel interface needed by Dropwizard. This will allow for cleaner transition to jakarta-only dependencies
…nder DPC control and updated for jakarta/hk2 support
NavaCharlesHorowitz
force-pushed
the
ceh1/tech-debt-oct24-3
branch
from
e9fcd5f
to
aa17336
Compare
NavaCharlesHorowitz
changed the title
added 3 commits
November 22, 2024 09:27
…Adapter and made changes consistent with security model for JWTs to not rely on claims prior to signature verification. Updated exception->response mapping Tests updates and improved test isolation Added DAO method to fetch key using keyid without org id Updated POMs for transitive dependencies
Swapped-in dropwizard-guiciest hk2/jakarta/guice code/annotation adjustment transition to jakarta from javax Some performance/singleton adjustments Test updates and some further test isolation Exception->response mapping updates
…/tech-debt-oct24-1
NavaCharlesHorowitz
added
dependencies
| @@ -9,7 +9,7 @@ | |||
| import io.dropwizard.auth.AuthFilter; | |||
| import io.dropwizard.auth.Authenticator; | |||
|
|
|||
| import javax.inject.Inject; | |||
| import com.google.inject.Inject; | |||
There was a problem hiding this comment.
does it matter that you're using jakarta.inject in some places and com.google.inject in others?
There was a problem hiding this comment.
A good question - the answer appears to be - it can. The code as it is appears to be working (meaning to say that the guice-hk2 bridge is probably keeping it all together), but I'd definitely recommend if this ends up being accepted into main, then we should plan to thoroughly comb through and try to rectify that to eliminate the uncertainty of when which package should be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
This is one component of my catchall tech debt/housekeeping ticket:
DPC-4298
🛠 Changes
-Updated POMs with newer dependency versions
-Removed older jersey/guice/dropwizard utilities
-Updated classes for jakarta support and new guice/hk2/jakarta DI
-Removed deprecated code and some warnings
-Improved test isolation
-Performance adjustments
ℹ️ Context
Project dependencies are 4 - 8 years old. Deprecated code, EOL projects, increasingly inactive development community and inability to support eventual transition to JDK 17 are concerns that need to be addressed while preserving the basic integrity of the software design.
🧪 Validation
Local unit, integration, system, and smoke testing combined with trace logging to verify successful and correct implementation of new dependencies.