Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge project 1 changes #14

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Merge project 1 changes #14

merged 1 commit into from
Sep 23, 2024

Conversation

KesterTan
Copy link

Description

Refactored code depth of line 71-74 of src/user/uploads.js to reduce code depth from 4 to 3. This was done by abstracting the inner arrow function into a seperate function.

Soundcloud issue here.

UI Manual Test

  1. Create a topic
  2. Upload an image to the topic
  3. Navigate to user tab
  4. Click uploads and see that there is one upload for your profile
  5. Click delete beside the upload and note the console log in ./nodebb log
Screenshot 2024-08-28 at 7 16 06 PM

Coverage Test

This is covered by coverage tests as shown:
Screenshot 2024-08-28 at 6 03 01 PM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10927193181

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.671%

Totals Coverage Status
Change from base Build 10778349896: 0.0%
Covered Lines: 22324
Relevant Lines: 25583

💛 - Coveralls

Copy link

@philliparaujo philliparaujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work

@KesterTan KesterTan merged commit e690920 into f24 Sep 23, 2024
1 check passed
@philliparaujo philliparaujo added this to the Sprint 1 milestone Sep 25, 2024
@KesterTan KesterTan deleted the kester-project1 branch October 10, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants