Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translator code backend code #45

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Translator code backend code #45

merged 4 commits into from
Nov 14, 2024

Conversation

heyanuja
Copy link

@heyanuja heyanuja commented Nov 14, 2024

Python Flask web app that will perform live translations for input text integrated into nodebb code

Resolves #54


handleTopicSearch();

hooks.fire('action:topic.loaded', ajaxify.data);
};

function configurePostToggle() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How hard would it be to fix the lint errors? Even though our whole GitHub actions might not pass, it might be helpful to have as many files as possible follow ESLint guidelines. If it's too much work for the checkpoint, we can work on fixing it by Friday

@philliparaujo philliparaujo self-requested a review November 14, 2024 02:11
Copy link

@philliparaujo philliparaujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just make sure the new tests show up in CI

@heyanuja
Copy link
Author

Looks good overall, just make sure the new tests show up in CI

sounds good + will be adding that code in soon, thanks for looking at it! we can fix lint stuff after

@heyanuja heyanuja merged commit df391d1 into f24 Nov 14, 2024
0 of 2 checks passed
@KesterTan KesterTan linked an issue Nov 16, 2024 that may be closed by this pull request
@KesterTan KesterTan added the enhancement New feature or request label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add backend code for translator service
3 participants