Merging changes from US1 Implementation (Sprint 1) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* append each topic title with content preview * addressed lint errors * removed console log from P1
src/categories/topics.js: add attribute {content} to the topic object in the Categories.getCategoryTopics() function
node_modules/nodebb-theme/harmony/templates/partials/topics_list.tpl: add <div> to include topic.content in the topics_list page
display changes from an extra block next to the title to placing the content preview underneath the title
test whether the content has more than 100 characters and add '...' to contents that exceed the 100 character limit
Pull Request Test Coverage Report for Build 11189175819Details
💛 - Coveralls |
a1inachen
approved these changes
Sep 21, 2024
Michaelli8899
approved these changes
Sep 21, 2024
make changes to connect frontend changes to the nodebb-frontend-f24-team-bulbasaur repository: link to frontend repo: https://github.com/CMU-313/nodebb-frontend-f24-team-bulbasaur
This was
linked to
issues
Oct 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves Implement code for US1 feature #6, Identify the FE files which need to be changed in order to fulfil US1 #2, Identify the BE files which need to be changed in order to fulfil US1 #3, Create test cases for the implementation of US1 #4, Create UserGuide file #33, Validate code coverage remains the same/ higher than before implementation of US1 feature #5 for US1
Why?
These changes resolve US1, which is to allow students and instructors to preview the first few sentences of a post to get a quick understanding of what question is being asked. For more information, refer to US1 under "Team Bulbasaur User Stories" board.
How?
Category.getCategoryTopicsinsrc/categories/topics.jsfile, which GETs and displays all postsgetMainPostsfunctionnode-theme-harmony/templates/partials/topics_list.tpl, searched the GitHub repo for those same tags to locate where the tags were in the filesTesting?
TopicObject.yamlto ensure that response and schema alignedScreenshots
Successful implementation of US1 feature
Successful test run
Anything Else?
Thank you