Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding button to insert video link to "Create Topic Page" #28

Merged
merged 9 commits into from
Sep 24, 2024

Conversation

vsolskyyy
Copy link

@vsolskyyy vsolskyyy commented Sep 24, 2024

Adding a button to the "Create Topic Page" labelled "Video Link" with a video icon that allows users to insert a video url and have the video play directly on the nodeBB website. Fixes Issue: #16

I edited node_modules/nodebb-plugin-markdown/public/js/markdown.js to add a button to the markdown that asks for a video-url and when the user puts in the url, the video can play on the topic.
Screenshot 2024-09-24 at 8 22 16 PM

I edited node_modules/nodebb-plugin-markdown/index.js to include this new button I created after the image-link button, assigning a video icon to the button and labelling it "Video Link"
Screenshot 2024-09-24 at 8 24 55 PM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11021928627

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.671%

Totals Coverage Status
Change from base Build 10982176047: 0.0%
Covered Lines: 22323
Relevant Lines: 25582

💛 - Coveralls

@vsolskyyy vsolskyyy merged commit eba3d89 into CMU-313:f24 Sep 24, 2024
1 check passed
@vsolskyyy vsolskyyy linked an issue Sep 24, 2024 that may be closed by this pull request
@vsolskyyy vsolskyyy self-assigned this Oct 11, 2024
@vsolskyyy vsolskyyy added the enhancement New feature or request label Oct 11, 2024
@vsolskyyy vsolskyyy added this to the Sprint 2 Finish Point milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: Add a way to include videos in posts
2 participants