Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old - Created a Favorites Button for each Topic in Discussions page #9

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

alicekang1
Copy link

@alicekang1 alicekang1 commented Oct 11, 2024

This pull request solves Issue #31 in the main repository (CMU-313/nodebb-f24-sweethearts#31). Below is an explanation for the commits.


Pulled Cheyu's 'Favorite Posts' category in the post_bar.tpl. Did this a while ago, but forgot I realize I committed changes in the wrong branch.

Added the star button to the discussion page; however, formatting looked off. I wanted it to replicate the Gmail select and favorites button in the inbox section. I also committed these changes in the wrong branch.

Then replicated the Gmail inbox UI, with the star, square select button, and header next to each other instead of on top.

@alicekang1 alicekang1 requested a review from tu2463 October 11, 2024 01:56
@alicekang1 alicekang1 self-assigned this Oct 11, 2024
@alicekang1 alicekang1 merged commit f40fd87 into f24 Oct 11, 2024
@alicekang1 alicekang1 removed the request for review from tu2463 October 11, 2024 02:22
@jullia02 jullia02 changed the title Created a Favorites Button for each Topic in Discussions page Old - Created a Favorites Button for each Topic in Discussions page Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant