Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPA Locking Sanity and Memory leaks #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

LPA Locking Sanity and Memory leaks #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ssd/Address_Mapping_Unit_Page_Level.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1777,8 +1777,8 @@ namespace SSD_Components
MVPN_type mpvn = (MVPN_type)flash_controller->Get_metadata(addr.ChannelID, addr.ChipID, addr.DieID, addr.PlaneID, addr.BlockID, addr.PageID);
if (domains[block->Stream_id]->GlobalTranslationDirectory[mpvn].MPPN != Convert_address_to_ppa(addr)) {
PRINT_ERROR("Inconsistency in the global translation directory when locking an MPVN!")
Set_barrier_for_accessing_mvpn(block->Stream_id, mpvn);
}
Set_barrier_for_accessing_mvpn(block->Stream_id, mpvn);
} else {
LPA_type lpa = flash_controller->Get_metadata(addr.ChannelID, addr.ChipID, addr.DieID, addr.PlaneID, addr.BlockID, addr.PageID);
LPA_type ppa = domains[block->Stream_id]->GlobalMappingTable[lpa].PPA;
Expand Down
4 changes: 3 additions & 1 deletion src/ssd/Data_Cache_Manager_Flash_Advanced.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,9 @@ namespace SSD_Components
read_transfer_info->next_event_type = Data_Cache_Simulation_Event_Type::MEMORY_READ_FOR_CACHE_EVICTION_FINISHED;
read_transfer_info->Stream_id = user_request->Stream_id;
service_dram_access_request(read_transfer_info);
}
} else {
delete evicted_cache_slots;
}

//Issue memory write to write data to DRAM
if (dram_write_size_in_sectors) {
Expand Down
4 changes: 3 additions & 1 deletion src/ssd/Data_Cache_Manager_Flash_Simple.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,9 @@ namespace SSD_Components
read_transfer_info->next_event_type = Data_Cache_Simulation_Event_Type::MEMORY_READ_FOR_CACHE_EVICTION_FINISHED;
read_transfer_info->Stream_id = user_request->Stream_id;
service_dram_access_request(read_transfer_info);
}
} else {
delete evicted_cache_slots;
}

//Issue memory write to write data to DRAM
if (dram_write_size_in_sectors) {
Expand Down
1 change: 0 additions & 1 deletion src/ssd/Host_Interface_NVMe.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ inline void Input_Stream_Manager_NVMe::inform_host_request_completed(stream_id_t
void Input_Stream_Manager_NVMe::segment_user_request(User_Request *user_request)
{
LHA_type lsa = user_request->Start_LBA;
LHA_type lsa2 = user_request->Start_LBA;
unsigned int req_size = user_request->SizeInSectors;

page_status_type access_status_bitmap = 0;
Expand Down