Dev tmp odd channels #23
Conversation
…be updated to reflect new types of valid inputs
include/small/abstract_layer.hpp
Outdated
| printf("input col stride %d\n", input_col_stride); | ||
|
|
||
| #endif | ||
| FLOAT_ABSTRACT_OP_END(op_type, op_class, step, a_cur, b_cur, c_cur, W_elements, _C_ob); |
There was a problem hiding this comment.
I think, this is where arm/intrinsics.h is failing to compile: _C_ob is not constexpr as macro assumes (or the compiler is not advanced enough to ignore constexpr...why doesn't this fail on Zen2 platform?).
include/small/interface_abstract.hpp
Outdated
| throw std::invalid_argument( | ||
| "AveragePool2D<float> ERROR: in_channels unsupported."); | ||
| } | ||
| // else |
There was a problem hiding this comment.
missing code for odd channels?
There was a problem hiding this comment.
Haven't Tested odd channels for this layer type yet. Added the else back
include/small/abstract_layer.hpp
Outdated
| @@ -270,7 +276,7 @@ void inline kernel( | |||
| if (op_type == OP_MAX_POOL || op_type == OP_MUL) | |||
| { | |||
| /// @note using platform C_ob | |||
There was a problem hiding this comment.
With the change from FLOAT_C_ob to _C_ob, this comment is no longer correct. Remove?
include/small/abstract_layer.hpp
Outdated
| @@ -303,7 +309,7 @@ void inline kernel( | |||
| for (uint32_t ii = 0; ii < _F_cb / _UNROLL; ii++) | |||
| { | |||
| /// @note using platform C_ob | |||
There was a problem hiding this comment.
With the change from FLOAT_C_ob to _C_ob, this comment is no longer correct. Remove?
include/small/abstract_layer.hpp
Outdated
| * O: [G/G_b, K/K_b, O_h, O_w, G_b, K_b] | ||
| * | ||
| * For the case where the number of channels is not a multiple of the blocking size, | ||
| * I: |
There was a problem hiding this comment.
Missing new documentation
include/small/interface_abstract.hpp
Outdated
| { | ||
| // printf("Generic handling for input channels that are not a multiple\n"); | ||
| // printf("call parameters: "); | ||
| if (stride == 1) |
There was a problem hiding this comment.
ERROR(?) This new if was not indented properly and the closing brace is missing. I think it belongs at line 447-448. This also indicates that there is no unit test exercising this function.
include/small/interface_abstract.hpp
Outdated
| throw std::invalid_argument( | ||
| "ReLUActivation<float> ERROR: in_channels unsupported."); | ||
| } | ||
|
|
There was a problem hiding this comment.
TODO: add odd channel support for LeakyReLUActivation, Dropout, Softmax, Upsample, Accum, Bias, PartialBias?
No description provided.