Add error message when forgetting a name and fix bug with expectfail not working with unit names with special characters #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmrichard
approved these changes
Dec 14, 2023
|
🚀 [bumpr] Bumped! New version:v0.1.14 Changes:v0.1.13...v0.1.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
Fix #99
Description
This PR is pretty simple in that it adds a helpful error message to inform users when they forget to use the
NAMEkeyword or provide a value for it. It also raises a CPP exception when encountering to prevent anything weird from happening later and to give the user a proper stacktrace. Tests for this were also added.In the process of fixing this issue I discovered that the
expectfailtemplate did not work when the section name had spaces, because it was being inserted verbatim into aset()command without quotes. This was also fixed by adding bracket quotes around important substitutions, in both templates and in theexpectfail_subprocessmodule.