Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LABEL and LABEL_NAME to the ct_add_dir() function to specify CTes… #113

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

Risto97
Copy link
Contributor

@Risto97 Risto97 commented Sep 24, 2024

…t label for the tests

Is this pull request associated with an issue(s)?
Please list issues associated with this pull request, including closing words
as appropriate.
Resolves #112

Description
Describe what this pull request will accomplish.
It will allow for tests added with ct_add_dir to be labeled using LABEL and LABEL_NAME arguments.

  • LABEL will use label of the tests as relative directory path used with ct_add_dir call.
  • LABEL_NAME has higher priority and allows to label the tests in the directory to any name.

TODOs
For draft pull requests please include a list of what needs to be done and check
off items as you complete them.

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2024

CLA assistant check
All committers have signed the CLA.

@Risto97 Risto97 mentioned this pull request Sep 24, 2024
ryanmrichard
ryanmrichard previously approved these changes Sep 24, 2024
Copy link
Contributor

@zachcran zachcran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this! It is a simple implementation that adds a powerful functionality. I left a few minor suggestions that shouldn't break anything, but we'll see!

ryanmrichard and others added 2 commits September 24, 2024 15:25
@ryanmrichard ryanmrichard dismissed zachcran’s stale review September 24, 2024 20:52

Changes made and it's r2g.

@ryanmrichard ryanmrichard merged commit b07712e into CMakePP:master Sep 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test labels support
4 participants