Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make include_guard in overrides global #92

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

AutonomicPerfectionist
Copy link
Contributor

Is this pull request associated with an issue(s)?
Fixes a very strange bug discovered in CMakePP/CMaize#132 where calling message() would result in infinite recursion.

Description
Turns out include_guard() only works for the current scope by default, so we needed to add an argument to make it a global guard.

TODOs

  • Probably should investigate usages of include_guard() elsewhere as well

@ryanmrichard ryanmrichard merged commit 66ceac2 into master Nov 7, 2023
6 checks passed
@ryanmrichard ryanmrichard deleted the make-include-global branch November 7, 2023 19:00
Copy link

github-actions bot commented Nov 7, 2023

🚀 [bumpr] Bumped! New version:v0.1.9 Changes:v0.1.8...v0.1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants