Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter dates that are not within target date +/- synthalf #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jmichel-otb
Copy link

This PR adds date filtering when command-line parameters --date and --synthalf are both set.

Dates outside of date +/- synthalf are ignored by the processor.

@olivierhagolle
Copy link
Contributor

Merci Julien,
Was it not the case before ?
Olivier

@jmichel-otb jmichel-otb changed the title Filter dates that are not with target date +/- synthalf Filter dates that are not within target date +/- synthalf Dec 10, 2019
@jmichel-otb
Copy link
Author

According to @petket-5 no : all input xml are processed for some steps, even if the algorithm might set a very small weight for them.

If I understand well what @petket-5 told me, the optimal use is currently to select dates within the desired range beforehand and pass this selection to --input. With this PR, you can pass 3 years of data to --input, and all dates that do not fall in desired range will be ignored.

@petket-5
Copy link

@olivierhagolle This is correct. The products outside of a given synthalf could still be used as an input to WASP, even if their average impact weight was low (Specified in the weightdatemin parameter).

With this PR we remove this possibility as it allows users a clearer usage of WASP for a fixed window of products. You can directly run WASP on a whole time series of L2 products without 'worrying' that your 3A syntheses mix up uncontrollably.

I will try to check and merge the code this week,

Peter

@olivierhagolle
Copy link
Contributor

Thanks Peter and Jullien, I was not aware of that, and I prefer the new way of handling the dates !
Olivier

@jmichel-otb
Copy link
Author

Thanks @petket-5 , if you are worried about loosing a feature, we can add a command-line switch to enable/disable this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants