Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror TMP C to GCW UP #133

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Mirror TMP C to GCW UP #133

merged 1 commit into from
Apr 4, 2024

Conversation

bpbond
Copy link
Member

@bpbond bpbond commented Apr 4, 2024

Per @wilsonsj100 request in #116 , this PR adds some custom code to L1_normalize.qmd: after the normal file-write step, if we're handling data from TEMPEST control plot then change it to being GCW upland and write again. This mirrors the former into the latter.

Closes #116

@bpbond bpbond requested a review from stephpenn1 April 4, 2024 18:41
@stephpenn1
Copy link
Member

Very nice!
With the test data, I only see upland data added in the last file (see screenshot), is there a change over date? Shouldn't all these files have upland added? Or is this just because this test data is only a sample of the data.

Also, do you know why there is so many NAs in the same dataset for GCW? Just another product of the sampling taken for test data? Let me know if anything is unclear above.

image

@bpbond
Copy link
Member Author

bpbond commented Apr 4, 2024

TMP UP data only appear in the GCW data for November 2023 because we only have that month in the TMP raw test data:
Screenshot 2024-04-04 at 4 49 21 PM

@bpbond
Copy link
Member Author

bpbond commented Apr 4, 2024

why there is so many NAs in the same dataset for GCW

You mean NAs in the GCW_20231104-20231104_L1_v0-9.csv file that gets written?

@stephpenn1
Copy link
Member

For NAs I'm just quickly looking at one of the files. Actually, it looks like it's Na in the raw data too, so I think we're good to go
image

@bpbond bpbond merged commit b9164eb into main Apr 4, 2024
1 check passed
@bpbond bpbond deleted the gcw_new branch April 4, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mirror TEMPEST data into GCW
2 participants