顯示且能修改時區的議程表 #15

rileychh · 2024-04-09T10:05:51Z

從 COSCUP/2022 #21 搬過來的 PR，合併了衝突，還沒測試過。

Closes #2.

mirumodapon

選擇器會在 navbar 的上方，可能需要調整 z-index
我覺得可以調整一下在 width < 600px 選擇器的顯示
我覺得可以把選好的時區存進 localStrage 就不用每次都要重選

mirumodapon · 2024-04-30T09:16:34Z

src/modules/session/logic.ts

@@ -171,7 +168,7 @@ export function generateScheduleTable (elements: ScheduleElement[]): ScheduleTab
            const { hour, minute } = getPartsOfDate(d)
            return timePoints.findIndex(([h, m]) => h === hour && m === minute)
          })
-        const span = endIndex - startIndex
+        const span = Math.abs(endIndex - startIndex)


是有 session 有這方面的錯誤嗎？

我不確定這個修改的作用，它也是搬過來的 😅
該留著還是改回來？

先...改回來好了 XD

在 7f72694 改回來了

src/modules/session/logic.ts

mirumodapon · 2024-04-30T09:21:58Z

src/pages/Session.vue

+        :options="timeZoneOptions"
+        v-model="currentTimeZone"
+      />
+      <button


或許可以回到會場(台灣)時區？這部分之後可以討論一下

該把重設按鈕從當地時區改成會場時區，還是另外加一個按鈕？

我覺得選一個就好耶！

在 fb51b6f 改成會場時區了

mirumodapon · 2024-04-30T09:26:27Z

src/components/Session/ScheduleItem.vue

@@ -68,6 +69,10 @@ export default defineComponent({
    sessionId: {
      type: String,
      required: true
+    },
+    currentTimeZone: {


想確認一下這裡為什麼需要傳這個參數

看起來沒有用到，另外兩個元件也是相同的情況。我把他們移除了。

rileychh · 2024-05-09T14:14:18Z

選擇器會在 navbar 的上方，可能需要調整 z-index

為了在教室列表（z-index: 2）之上，我設成了 z-index: 3。建議該怎麽處理呢？

我覺得可以調整一下在 width < 600px 選擇器的顯示

雖然不知道為什麼無法置中，但大概用 white-space: nowrap 和 max-width 處理好了。

我覺得可以把選好的時區存進 localStrage 就不用每次都要重選

搞定。

mirumodapon · 2024-05-26T15:07:48Z

選擇器會在 navbar 的上方，可能需要調整 z-index

為了在教室列表（z-index: 2）之上，我設成了 z-index: 3。建議該怎麽處理呢？

我覺得可以調整一下在 width < 600px 選擇器的顯示

雖然不知道為什麼無法置中，但大概用 white-space: nowrap 和 max-width 處理好了。

我覺得可以把選好的時區存進 localStrage 就不用每次都要重選

搞定。

z-index 設成 0 看起來 OK，教室列表之上是什麼意思啊

rileychh · 2024-05-27T13:07:20Z

⬆️ .time-zone-container { z-index: 0; } 長這樣

⬆️ .time-zone-container { z-index: 3; } 長這樣

1. 將TIMEZONE_OFFSET加入useSession 2. 新增watch觀測TIMEZONE_OFFSET並重新渲染 Cherry-picked to 2024 by Riley Co-authored-by: Chenghsuan Ho <[email protected]>

Cherry-picked to 2024 by Riley Co-authored-by: Chenghsuan Ho <[email protected]

Cherry-picked to 2024 by Riley Co-authored-by: Chenghsuan Ho <[email protected]>

1. 移除未使用的程式碼 2. 將 `@types/lodash` 替換成 `@types/lodash-es`

- 使用 `vue-search-select` 作為時區選擇元件 - 更新 `typescript` 到 `5.1` 以支援 `Intl.supportedValuesOf`

Implemented by binding currentTimeZone as the key of the component. Learn more: https://michaelnthiessen.com/force-re-render/

rileychh · 2024-07-04T15:56:30Z

謝謝 @mirumodapon 幫忙修好 z-index 的問題！
我再加上了修改時區後清除輸入的功能，用起來更方便。

rileychh self-assigned this Apr 9, 2024

rileychh force-pushed the time-zone-filter branch from 44372a1 to a4aebd6 Compare April 12, 2024 14:59

rileychh marked this pull request as ready for review April 12, 2024 15:00

rileychh requested a review from mirumodapon April 12, 2024 15:00

mirumodapon requested changes Apr 30, 2024

View reviewed changes

rileychh force-pushed the time-zone-filter branch from 34c12dc to d666782 Compare May 9, 2024 13:51

rileychh requested a review from mirumodapon May 9, 2024 14:14

rileychh force-pushed the time-zone-filter branch from fb51b6f to 347e4e6 Compare May 27, 2024 13:41

rileychh and others added 19 commits July 4, 2024 23:44

feat: change default time zone the conference time

8635a46

feat: change default time zone the conference time

e03f370

feat : 修改TIMEZONE_OFFSET

71c9f76

1. 將TIMEZONE_OFFSET加入useSession 2. 新增watch觀測TIMEZONE_OFFSET並重新渲染 Cherry-picked to 2024 by Riley Co-authored-by: Chenghsuan Ho <[email protected]>

feat : 切換時區跨日設定

1be7d1a

Cherry-picked to 2024 by Riley Co-authored-by: Chenghsuan Ho <[email protected]

feat : 時區輸入驗證

8e677ed

feat : 將period還原成原本的版本

bd30127

Cherry-picked to 2024 by Riley Co-authored-by: Chenghsuan Ho <[email protected]>

chore: 修正 ESLint 錯誤

ba0b244

1. 移除未使用的程式碼 2. 將 `@types/lodash` 替換成 `@types/lodash-es`

chore: 還原不必要的修改

378ccb9

refactor: 簡化 timezone.ts

5244c61

feat: 重製時區選擇 UI

ade57ef

- 使用 `vue-search-select` 作為時區選擇元件 - 更新 `typescript` 到 `5.1` 以支援 `Intl.supportedValuesOf`

feat: 新增時區選擇 i18n

be5ad77

fix: 時區選擇重設按鈕未顯示時置中選單

4403d56

chore: 編輯 copyright

00f0cc4

refactor: use the composition API of vue-i18n

7014ceb

refactor: remove unused prop currentTimeZone in Schedule*.vue

2a8acac

fix: adjust time zone selector styles for viewport width < 600px

cd6f5b7

feat: save selected time zone to local storage

f6fb6c9

chore: revert Math.abs in logic.ts added for unknown reasons

af6f9fd

feat: change default time zone the conference time

9d8f694

rileychh and others added 4 commits July 4, 2024 23:49

chore: update pnpm-lock.yaml

78077cc

Fix: z-index style

1a17157

fix: add missing date-fns-tz dependency

140e1b2

feat: clear input on time zone change

402086a

Implemented by binding currentTimeZone as the key of the component. Learn more: https://michaelnthiessen.com/force-re-render/

rileychh force-pushed the time-zone-filter branch from ef9e1d9 to 402086a Compare July 4, 2024 15:54

mirumodapon merged commit 73e03ee into master Jul 16, 2024

rileychh mentioned this pull request Jul 31, 2024

顯示且能修改時區的議程表（第二次） #33

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

顯示且能修改時區的議程表 #15

顯示且能修改時區的議程表 #15

rileychh commented Apr 9, 2024 •

edited

Loading

mirumodapon left a comment

mirumodapon Apr 30, 2024

rileychh May 9, 2024

mirumodapon May 26, 2024

rileychh May 27, 2024

mirumodapon Apr 30, 2024

rileychh May 9, 2024

mirumodapon May 26, 2024

rileychh May 27, 2024

mirumodapon Apr 30, 2024

rileychh May 9, 2024

rileychh commented May 9, 2024

mirumodapon commented May 26, 2024

rileychh commented May 27, 2024

rileychh commented Jul 4, 2024

顯示且能修改時區的議程表 #15

顯示且能修改時區的議程表 #15

Conversation

rileychh commented Apr 9, 2024 • edited Loading

mirumodapon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rileychh commented May 9, 2024

mirumodapon commented May 26, 2024

rileychh commented May 27, 2024

rileychh commented Jul 4, 2024

rileychh commented Apr 9, 2024 •

edited

Loading