Support JRA55-do

[ezhilsabareesh8]

Updated datm_datamode_jra_mod.f90 to support JRA-55 do

[aekiss]

this file should be moved to a JRA55do1.4.0-RYF fork of the MOM6-CICE6 configuration https://github.com/COSIMA/MOM6-CICE6

[aekiss]

This file also needs to be updated to use the RYF inputs from /g/data/ik11/inputs/JRA-55/RYF/v1-4 - see fields with "domain": "land" in https://github.com/COSIMA/1deg_jra55_ryf/blob/master/atmosphere/forcing.json

[aekiss]

this file should be moved to a JRA55do1.4.0-RYF fork of the MOM6-CICE6 configuration https://github.com/COSIMA/MOM6-CICE6

[aekiss]

So there will need to be a corresponding PR in https://github.com/COSIMA/MOM6-CICE6

[aekiss]

This file also needs to be updated to use the RYF inputs from /g/data/ik11/inputs/JRA-55/RYF/v1-4 - see https://github.com/COSIMA/1deg_jra55_ryf/blob/master/atmosphere/forcing.json

[aekiss]

We may want to pass this up to CDEPS, so to avoid clashing with the original it should be renamed as datm_datamode_jra55do_mod.F90 and the module and subroutine names changed to match. Also need to duplicate and modify this code block

[aekiss]

don't comment out

[aekiss]

change to extra_sources/datm_datamode_jra55do_mod.F90

[aekiss]

Thanks @ezhilsabareesh8. I've made a few suggestions - if you push these changes to this branch the pull request will be automatically updated

[aekiss]

Thanks for the update @ezhilsabareesh. There's an issue with cmake - see checks

[aekiss]

ah, never mind - I see you're onto it already!

[ezhilsabareesh8]

Thanks @aekiss for the suggestions. I have incorporated all the suggestions except duplicating and modifying these lines of DATM caps, since a branch name is required to modify CDEPS code. Could you please advise in which branch I need to make these changes?

[aekiss]

Ah, good point.

At some later stage we might want to have our own fork of CDEPS and use that as a submodule in ACCESS-OM3 so we can push our own branches there.

But for now at this early testing stage I think you should copy atm_comp_nuopc.F90 to CDEPS/extra_sources and change CDEPS/CMakeLists.txt to use this copy instead of the original.

[aekiss]

Thanks @ezhilsabareesh8

FYI the CI compile test seems to sometimes fail with core dump but when restarted it's usually ok

[ezhilsabareesh8]

Thanks @aekiss. I have updated atm_comp_nuopc.F90 and included it in CDEPS/extra_sources. CDEPS/CMakeLists.txt is updated to use CDEPS/extra_sources/atm_comp_nuopc.F90 instead of the original.

[aekiss]

I've just pushed some minor tweaks.

More changes are needed in atm_comp_nuopc.F90 - @ezhilsabareesh8 can you please search for "jra" and duplicate and modify the relevant code to support a new datamode 'JRA55do' that calls your JRA55-do subroutines?

[ezhilsabareesh8]

Thanks @aekiss, datamode JRA55do is added to atm_comp_nuopc.f90 and the relevant code is modified to support JRA55do