Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in mom_cap.f90 for correct timestamp #46 #56

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

ezhilsabareesh8
Copy link
Contributor

@ezhilsabareesh8 ezhilsabareesh8 commented Aug 15, 2023

Addressed timestamp issue in MOM6 by modifying mom_cap.f90 (#46), ensuring correct restart filename generation

@dougiesquire
Copy link
Collaborator

For the other reviewers, the line that was changed in mom_cap.f90 is L1675:

call ESMF_TimeGet (MyTime, yy=year, mm=month, dd=day, h=hour, m=minute, s=seconds, rc=rc )

was changed to

call ESMF_TimeGet (MyTime, yy=year, mm=month, dd=day, s=seconds, rc=rc )

Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks @ezhilsabareesh8!

Copy link
Contributor

@aekiss aekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - nice detective work @ezhilsabareesh8

@aekiss
Copy link
Contributor

aekiss commented Aug 16, 2023

@micaeljtoliveira what's the best approach to merging this, given what you're doing with the new main branch?

@micaeljtoliveira
Copy link
Contributor

@aekiss I will take care of merging it manually, as this branch will need a rebase.

@micaeljtoliveira
Copy link
Contributor

I'm merging this into the master branch. I will later cherry-pick the commit and make some changes to the way how we handle this kind of fixes in the main branch.

@micaeljtoliveira micaeljtoliveira merged commit b0325e7 into master Aug 31, 2023
@micaeljtoliveira micaeljtoliveira deleted the iss46-correct-time_stamp branch August 31, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants