Exception -> ValueError

COSIMA · Sep 6, 2023 · c423f52 · c423f52
1 parent aa5ed7a
commit c423f52
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/regional_mom6/regional_mom6.py b/regional_mom6/regional_mom6.py
@@ -305,7 +305,7 @@ def quadilateral_area(v1, v2, v3, v4):
         & np.isclose(np.dot(v1, v1), np.dot(v3, v3))
         & np.isclose(np.dot(v1, v1), np.dot(v4, v4))
     ):
-        raise Exception("vectors provided must have the same length")
+        raise ValueError("vectors provided must have the same length")
 
     R = np.sqrt(np.dot(v1, v1))
 

diff --git a/tests/test_grid_generation.py b/tests/test_grid_generation.py
@@ -64,7 +64,7 @@ def test_quadilateral_area(v1, v2, v3, v4, true_area):
 
 
 def test_quadilateral_area_exception():
-    with pytest.raises(Exception) as excinfo:
+    with pytest.raises(ValueError) as excinfo:
         quadilateral_area(v1, v2, v3, v4)
 
     assert str(excinfo.value) == "vectors provided must have the same length"