Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds interactive domain selection via a map in the ACCESS-OM2 demo #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reillyja
Copy link
Collaborator

@reillyja reillyja commented Apr 2, 2024

I've just added an interactive way of setting out the domain boundaries where you can just click and drag a box and it saves the associated boundary coordinates. It's not super clean but I can fix that up if its worth keeping.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ashjbarnes
Copy link
Collaborator

Thanks @reillyja ! This looks great - would we be able to incorporate your functions into the library itself so they can be imported from the package? I think it would be a matter of copy pasting and providing docstrings that are consistent with the format of the other functions in the package. That is if you're happy with this code becoming part of the repo of course!

This feature will be really helpful when Copernicus finishes replacing the old motu requests thing. Then we can build a new automatic data download function, incorporating these functions. For now we need to do the download by hand from their GUI while their API is down.

@navidcy navidcy changed the title added interactive map to access demo Adds interactive domain selection via a map in the ACCESS-OM2 demo Apr 8, 2024
@navidcy
Copy link
Contributor

navidcy commented Apr 23, 2024

This sounds like a great feature. Does it only work with ACCESS-OM2?

@ashjbarnes
Copy link
Collaborator

@reillyja Copernicus has finished updating their auto download feature again and I've got some scripts ready to that'll do the auto-downloading. Would you be able to incorporate your functions on Gadi into the repo so they can be built into the package?

@navidcy
Copy link
Contributor

navidcy commented Apr 23, 2024

@reillyja, #162 deleted this example, but the intention is to move it to cosima-recipes; see COSIMA/cosima-recipes#338

@reillyja
Copy link
Collaborator Author

@reillyja Copernicus has finished updating their auto download feature again and I've got some scripts ready to that'll do the auto-downloading. Would you be able to incorporate your functions on Gadi into the repo so they can be built into the package?

Sorry - just saw this! Yes I can definitely look at adding this to the package. What's the timeline for getting this stuff done? i.e., can I look into this once we're on the boat @ashjbarnes? Just a bit snowed in at the moment

@ashjbarnes
Copy link
Collaborator

ashjbarnes commented Aug 21, 2024

@reillyja Hey John I've just made a new branch called glorys-function which has functions for automatically making the Glorys downloads. Probably a good time to add your widget now! Let us know if you have any questions about incorporating functions into the main mom6-regional.py file :)

What would be really nice is if you could create an experiment object like normal, but if you set "select_domain = True" then your widget pops up, which in turn writes the longitude_extent properties of the expt object. Then you could just run the rest of the notebook start to finish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants