Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic PyPI upload on GitHub release #151

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Automatic PyPI upload on GitHub release #151

merged 4 commits into from
Apr 23, 2024

Conversation

angus-g
Copy link
Collaborator

@angus-g angus-g commented Apr 17, 2024

Releases marked as "prerelease" will go to TestPyPI, for workflow testing, etc. Just as an option for #110, probably good to get @dougiesquire's feedback.

@navidcy
Copy link
Contributor

navidcy commented Apr 17, 2024

This closes #110, right?

@angus-g
Copy link
Collaborator Author

angus-g commented Apr 17, 2024

Except for the docs tags (for which I've just added an RTD automation to auto-activate version tags). It does mean you should create new package releases via a GitHub release rather than pushing a tag though.

Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@navidcy navidcy linked an issue Apr 17, 2024 that may be closed by this pull request
@navidcy
Copy link
Contributor

navidcy commented Apr 17, 2024

@angus-g, merge?

@angus-g
Copy link
Collaborator Author

angus-g commented Apr 17, 2024

I'll just do one quick test, then I'll merge!

@navidcy
Copy link
Contributor

navidcy commented Apr 17, 2024

take your time!

Releases marked as "prerelease" will go to TestPyPI, for workflow
testing, etc.
This will fill out the PyPI project page, and also prevent an error
during the check phase of the packaging workflow.
@angus-g
Copy link
Collaborator Author

angus-g commented Apr 17, 2024

Alright, figured out that we need the readme key in the project file, otherwise the workflow will complain. Also fixed a typo. I think this is good to go now!

@navidcy
Copy link
Contributor

navidcy commented Apr 23, 2024

@angus-g, this closes #152, right?

@navidcy navidcy linked an issue Apr 23, 2024 that may be closed by this pull request
@angus-g
Copy link
Collaborator Author

angus-g commented Apr 23, 2024

Should do, yeah.

@navidcy navidcy merged commit 8e598a7 into main Apr 23, 2024
5 checks passed
@navidcy navidcy deleted the angus-g/pypi-upload branch April 23, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPI doesn't see any "Project description" Proper/better way to tag new releases?
3 participants