Pin numpy<2.0.0 #178
Merged
Pin numpy<2.0.0 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the new error we're seeing is an incompatibility between xESMF and numpy 2.0.0 (maybe): 32-bit ints are not big enough to represent the products of the dimensions, and I wonder if the overflow there is causing it to fail a check somewhere: The fix for the moment might be to just pin numpy to <2.0.0. |
There are still a few incompatibilities with numpy 2.0.0, so we'll pin the previous version for the moment. In particular, xESMF regridders can't handle large grids with a number of points that overflows a 32-bit integer.
|
Nice! Ok should we merge this right away and rebase all active PRs back to |
ashjbarnes
approved these changes
Jul 1, 2024
|
FYI: Previously I tried to add 3.11 to the CI and failed; see #105 |
|
How odd that it's the only one to hang! |
|
I'm happy to just remove the 3.11 tbh... |
For some reason it seems to hang indefinitely. We'll just disable it for the moment (3.12 works, anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess it's nice that we have type information encoded here now too. This does introduce a bit of an incompatibility in the testing environment, where numpy 2.0.0 is required, but it's not an issue for actual running.Famous last words: it is an issue for running, at the moment. We will probably just have to restrict ourselves to numpy < 2.0.0 for the moment.