-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ObstacleDetection instances, attributes and Adaptive CruiseControl #780
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -86,6 +86,17 @@ CruiseControl.IsError: | |
type: sensor | ||
description: Indicates if cruise control system incurred an error condition. True = Error. False = No Error. | ||
|
||
CruiseControl.IsAdaptive: | ||
datatype: boolean | ||
type: actuator | ||
description: Indicates if cruise control system is adaptive (i.e. actively controls speed). | ||
|
||
CruiseControl.AdaptiveDistanceSet: | ||
datatype: float | ||
type: actuator | ||
unit: m | ||
description: Distance in meters to keep from lead vehicle | ||
|
||
# | ||
# Lane Departure Detection System | ||
# | ||
|
@@ -113,6 +124,9 @@ LaneDepartureDetection.IsError: | |
# | ||
ObstacleDetection: | ||
type: branch | ||
instances: | ||
- ["Front", "Rear"] | ||
- ["Left", "Center", "Right"] | ||
description: Signals form Obstacle Sensor System. | ||
|
||
ObstacleDetection.IsEnabled: | ||
|
@@ -131,6 +145,28 @@ ObstacleDetection.IsError: | |
type: sensor | ||
description: Indicates if obstacle sensor system incurred an error condition. True = Error. False = No Error. | ||
|
||
ObstacleDetection.Distance: | ||
datatype: float | ||
type: sensor | ||
unit: m | ||
description: Distance in meters to detected object | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can never be negative, or? And distance is distance from the specified "zone". I.e. an object just in front of the front number plate may be reported with distance==0.01 meter by Front.Center, but with distance==0.80 meter by Front.Right? |
||
|
||
ObstacleDetection.TimeGap: | ||
datatype: int32 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Has negative number a meaning, or would uint32 suffice? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unsigned is fine but wanted decimal instead of rounding to full integer. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If no meaning - shall we use uint32, i.e. up to 65 seconds? |
||
type: sensor | ||
unit: ms | ||
description: Time in milliseconds before potential impact object | ||
|
||
ObstacleDetection.WarningType: | ||
datatype: string | ||
type: sensor | ||
allowed: [ | ||
'UNDEFINED', # Object detection warning not further categorized | ||
'CROSS_TRAFFIC', # Detected object is on an indirect trajectory that may intersect | ||
'BLIND_SPOT', # Detected object may not be in driver line of sight, including from mirrors | ||
] | ||
description: Indicates the type of obstacle warning detected as some track not only the presence of an obstacle but potential intercepting trajectory or other characteristics. | ||
comment: Undefined obstacle warning type would merely alert of presence of obstacle and may measure distance. | ||
|
||
# | ||
# Antilock Braking System | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the instances also for the existing signals like
IsEnabled
,IsWarning
and so on? If not we could split to two branches, one calledObstacleDetection
(without instances) and one calledObstacles
(with instances)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each ObstacleDetection sensor could throw a separate warning, be disabled independently etc,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous conversation before considering instances approach
#770