Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Routing-Manager State. #653

Closed
wants to merge 1 commit into from
Closed

Conversation

akhzarj
Copy link
Contributor

@akhzarj akhzarj commented Mar 18, 2024

Author: Aram Khzarjyan [email protected], MBition GmbH.

Initialize Routing-Manager State. #653

To avoid undefined behavior the state have to be initialized.


The program was tested solely for our own use cases, which might differ from yours.

The submission is provided under the main project license (LICENSE file in root of project).

Provider Information

@akhzarj akhzarj marked this pull request as draft March 18, 2024 11:51
@kheaactua
Copy link
Contributor

You beat my PR by one day :) #655

@akhzarj akhzarj changed the title Fix Routing-Manager State Initialization. Initialize Routing-Manager State. Mar 21, 2024
To avoid undefined behavior the state have to be initialized.

Co-authored-by: Aram Khzarjyan <[email protected]>
Co-authored-by: Mateusz Golba <[email protected]>
Signed-off-by: Gunnar Andersson <[email protected]>
@gunnar-mb
Copy link

PR looks good to me.

@akhzarj akhzarj marked this pull request as ready for review March 22, 2024 15:53
@fcmonteiro
Copy link
Collaborator

Fix will be included in our vSomeIP 3.5.1,
865f1db

@fcmonteiro fcmonteiro closed this Jul 29, 2024
duartenfonseca pushed a commit that referenced this pull request Nov 8, 2024
Summary
Allow to configure the initial routing state to allow suspended startup
Details
Add a configuration parameter service-discovery.initial_state to allow the configuration of the behavior
on startup. Additionally, ensure that new endpoints that are created while the routing is suspended are
not started. This will happen on the next resume.
Issue

https://jira.cc.bmwgroup.net/browse/ICONSD-77536

Reviewed-by: diogopedrosa <[email protected]>
Reviewed-by: anarodrigues <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants