Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stringcase dependency #188

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

erikbosch
Copy link
Collaborator

@erikbosch erikbosch commented Aug 25, 2022

We do not seem to use the functionality, and stringcase might (in some way) trigger the build problems we sometimes see. This PR tests removing it.

NOTE:

As can be seen in this PR stringcase can be easily removed as we actually do not use the functionality, we always use NONE as formatting. The question to be discussed is if we want to remove it, or rather refactor to use another library in case any tool would need it in the future.

@erikbosch erikbosch marked this pull request as ready for review August 25, 2022 07:38
@erikbosch erikbosch force-pushed the erikbosch/erik_stringcase branch 2 times, most recently from 1ce6eca to 1263008 Compare August 25, 2022 10:18
@erikbosch erikbosch marked this pull request as draft August 25, 2022 13:47
@erikbosch erikbosch marked this pull request as ready for review August 25, 2022 13:47
@erikbosch
Copy link
Collaborator Author

I would like to get comments on:

@erikbosch
Copy link
Collaborator Author

Meeting notes: Seems OK to remove. Please review change until next meeting

Copy link
Collaborator

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works (fresh install in new pipenv, and ran all the non-contrib tools)
I "ugly" with the Git webui fixed the merge conflict in setup.py (py 3.7 vs. 3.8). Feel free to niceify via force-push

Signed-off-by: Erik Jaegervall <[email protected]>
@erikbosch erikbosch force-pushed the erikbosch/erik_stringcase branch from 646838f to f97d048 Compare September 8, 2022 07:20
@erikbosch erikbosch merged commit 9d53764 into COVESA:master Sep 8, 2022
@erikbosch erikbosch deleted the erikbosch/erik_stringcase branch February 22, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants