Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] notice 관련 기능 구현 #16

Merged
merged 33 commits into from
Oct 15, 2023
Merged

[feature] notice 관련 기능 구현 #16

merged 33 commits into from
Oct 15, 2023

Conversation

k-kbk
Copy link
Collaborator

@k-kbk k-kbk commented Sep 27, 2023

해당 PR이 어떤 것을 하나요?

  • notice 기본 CRUD 기능 구현

고민(선택)

  • id가 nullable해서 null aseertion(!!)을 계속 사용해야 하는게 조금 찝찝하다(그래서 우테코에서는 0L로 쓰는 듯?)
  • update 개선?

기획 문서 혹은 태스크 관련 링크

@github-actions github-actions bot added the feature 기능 개발 및 테스트 작성 label Sep 27, 2023
Copy link
Member

@dojinyou dojinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cateogry pr 참고해서 update하고 다시 리뷰 요청해주세연

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #16 (92d3852) into main (2c0eb29) will increase coverage by 1.75%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 92d3852 differs from pull request most recent head 7603c51. Consider uploading reports for the commit 7603c51 to get more accurate results

@@             Coverage Diff              @@
##               main      #16      +/-   ##
============================================
+ Coverage     89.15%   90.90%   +1.75%     
- Complexity      177      213      +36     
============================================
  Files            30       38       +8     
  Lines           332      396      +64     
  Branches         11       12       +1     
============================================
+ Hits            296      360      +64     
  Misses           26       26              
  Partials         10       10              
Files Coverage Δ
...in/com/mjucow/eatda/domain/notice/entity/Notice.kt 100.00% <100.00%> (ø)
...ain/notice/service/command/NoticeCommandService.kt 100.00% <100.00%> (ø)
.../notice/service/command/dto/CreateNoticeCommand.kt 100.00% <100.00%> (ø)
.../notice/service/command/dto/UpdateNoticeCommand.kt 100.00% <100.00%> (ø)
.../domain/notice/service/query/NoticeQueryService.kt 100.00% <100.00%> (ø)
...eatda/domain/notice/service/query/dto/NoticeDto.kt 100.00% <100.00%> (ø)
...w/eatda/domain/notice/service/query/dto/Notices.kt 100.00% <100.00%> (ø)
...n/com/mjucow/eatda/domain/store/entity/Category.kt 100.00% <ø> (ø)
...ucow/eatda/presentation/notice/NoticeController.kt 100.00% <100.00%> (ø)
.../presentation/store/category/CategoryController.kt 100.00% <ø> (ø)

@Column(nullable = false)
var title: String = ""
set(value) {
validateValue(value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title은 길이 제한에 대해서도 검증이 되어야 할 것 같음!

src/test/resources/application.yml Show resolved Hide resolved
Copy link
Member

@dojinyou dojinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci 깨지는 것만 정리하고 squash merge ㄱㄱ

@k-kbk k-kbk merged commit 3379581 into main Oct 15, 2023
2 of 3 checks passed
@k-kbk k-kbk deleted the notice branch October 15, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 기능 개발 및 테스트 작성 size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants