Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #57 from COW-dev/main #61

Merged
merged 1 commit into from
Nov 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ jobs:
DB_URL=${{ secrets.DB_URL }}
DB_USERNAME=${{ secrets.DB_USERNAME }}
DB_PASSWORD=${{ secrets.DB_PASSWORD }}
REDIS_URL=${{ secrets.REDIS_URL }}
REDIS_PORT=${{ secrets.REDIS_PORT }}
REDIS_URL=${{ secrets.REDIS_URL }}
tags: |
eatda/api-server:latest

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ class StoreQueryService(
}

fun findById(storeId: Long): StoreDetailDto {
val entity = repository.getReferenceById(storeId)
// FIXME(async): findById가 popular store command 과정에서 실패하지 않도록 비동기 호출 처리
popularStoreCommandService.setStore(storeId)
return StoreDetailDto.from(repository.getReferenceById(storeId))
return StoreDetailDto.from(entity)
}
}
1 change: 0 additions & 1 deletion src/main/resources/application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ spring:
data:
redis:
host: ${REDIS_URL}
port: ${REDIS_PORT}

jooq:
sql-dialect: postgres