[2주차] 이성진 학습 PR 제출합니다. #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leesj0188
requested review from
swgvenghy,
ujinsimSS and
keemsebin
as code owners
keemsebin
reviewed
Oct 6, 2024
|
swgvenghy
requested changes
Oct 7, 2024
keemsebin
reviewed
Oct 10, 2024
week02/이성진/todo/src/App.jsx
Outdated
|
|
||
| function App() { | ||
| const [inputValue,setInputValue] = useState('') | ||
| const [todolist,setTodolist]=useState([]) |
There was a problem hiding this comment.
전체적으로 일관성있게 카멜케이스 적용하면 좋을 것 같아요.
ujinsimSS
reviewed
Oct 10, 2024
| 4. **JSX는 반드시 하나의 부모태그가 감싸는 형식이어야 한다**. | ||
| - React 내에서 Virtual DOM이 내부의 요소들의 변화를 감지할 때, 효율적인 비교를 위해 DOM 트리를 구성해야 한다. 따라서 코드를 작성할 때 **<div>** 로 감싸주어야 한다. | ||
|
|
||
| 5. **모든 프로퍼티의 표기는 CamelCase로 작성한다.** |
There was a problem hiding this comment.
다른 네이밍 규칙에는 어떤 것이 있을까요??
컴포넌트 명명 규칙은 무엇일까요 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 학습 내용 요약
🤔 고민했던 부분
🔊 도움이 필요한 부분