PR for Release 1.4.0 #320

huispaty · 2023-09-22T13:18:11Z

New Features

new class for performed notes
minimal unfolding for part
updated Musescore parser for version 4
load_score auto-selects parser based on file type
new attributes for Score object for capturing meta information
new score note attributes in matchfile export (grace, voice_overlap)
new tempo_indication score property line in matchfile export

Bug Fixes

Other Changes

new unit test for cross-staff beaming for musicxml

…ng any exception for xml files

Installing Musescore dependency only for linux runner. The tests should be accordingly adapted.

…musescore4

Installing Musescore dependency only for linux runner. The tests should be accordingly adapted.

…d MEI parsing

…musescore4

…lets

…ed test accordingly

Also changed unfolding_part_minimal and unfolding part_maximal to work with scores.

…attributes, note id fix in load_performance_midi, optional track merging param in save_performance_midi

adds a function to directly generate minimally unfolded parts/scores.

Solves #299 Solves #298 Solved #297

Added an extra clause in find musescore to check whether a screen is available.

codecov-commenter · 2023-09-22T15:48:45Z

Codecov Report

Patch coverage is 72.97% of modified lines.

Files Changed	Coverage
partitura/directions.py	`ø`
partitura/io/matchlines_v1.py	`ø`
partitura/score.py	`39.02%`
partitura/io/matchfile_utils.py	`41.17%`
partitura/io/musescore.py	`42.30%`
tests/test_pianoroll.py	`50.00%`
partitura/io/exportmatch.py	`52.38%`
partitura/io/exportmidi.py	`66.66%`
partitura/io/importmei.py	`67.30%`
partitura/performance.py	`71.69%`
... and 13 more

📢 Thoughts on this report? Let us know!.

partitura/io/importmidi.py

partitura/io/musescore.py

partitura/performance.py

tests/test_musescore.py

tests/test_tonal_tension.py

sildater · 2023-09-25T10:34:35Z

A general question, this PR links issue #293 which is not really addressed. The same behavior that was mentioned still persists. However, we probably also won't change it, so I just tried to give some details around it. How should we handle this? Should we keep this open? Or have some kind of FAQ section somewhere? I sometimes write these longer explanations on issues and would like them to stay around somewhere after we close the issue.

…to perform like one. This avoids internal recursions.

partitura/performance.py

# Conflicts: # partitura/performance.py

…g screens on servers.

manoskary and others added 30 commits July 18, 2023 12:27

new class for performedNotes.

a9ee5cd

add support for musescore 4

966034e

correct musescore import bug

414e54e

added tests and corrected problem in kern import which was not throwi…

eae4d4f

…ng any exception for xml files

update workflow:

660b748

Installing Musescore dependency only for linux runner. The tests should be accordingly adapted.

added skiptest for github actions

35eba7a

Merge branch 'musescore4' of https://github.com/CPJKU/partitura into …

2671711

…musescore4

update workflow:

333c8b9

Installing Musescore dependency only for linux runner. The tests should be accordingly adapted.

Merge remote-tracking branch 'origin/musescore4' into musescore4

e63970a

Attempt to fix syntax error on workflow file.

eff27f3

Third Attempt to fix syntax error on workflow file.

3488684

better function naming in test_load_score test. Stop condition for ba…

6b33d9a

…d MEI parsing

Merge branch 'musescore4' of https://github.com/CPJKU/partitura into …

120a918

…musescore4

some MEI bugfixes

3befc24

Deleted 4 useless test files, bugfixes on MEI import with strange tup…

dc01764

…lets

removed problematic test that was using musescore 4

0f37837

removed file

302adcf

Measures have only start and no end, like in import musicxml. Correct…

31aa38c

…ed test accordingly

add force flags for musescore

920856d

updated workflow to install musescore3

c25cd52

Removed Musescore Tests, because they can't run on github

4e883e7

added unfolding part minimal:

1ce4a02

Also changed unfolding_part_minimal and unfolding part_maximal to work with scores.

new score attributes and score prop line for match export, new Score …

4be4bbe

…attributes, note id fix in load_performance_midi, optional track merging param in save_performance_midi

Minor edit on line break to re-launch tests

0f24a16

Suggested edit by review.

5c12147

updated load_score test to a better coding style

b9ff8db

Merge pull request #302 from CPJKU/unfolding_updates_

f919945

adds a function to directly generate minimally unfolded parts/scores.

Format code with black (bot)

a5993b0

Merge pull request #296 from CPJKU/musescore4

5fe996d

Solves #299 Solves #298 Solved #297

Format code with black (bot)

7fdd582

huispaty added 2 commits September 22, 2023 17:13

Update conf.py

5a400bd

Update CHANGES.md

adc00db

huispaty changed the title ~~PR for Release 1.3.2~~ PR for Release 1.4.0 Sep 22, 2023

huispaty and others added 3 commits September 22, 2023 17:24

fixed musescore testing

69bfe5a

Update musescore.py

027344e

Added an extra clause in find musescore to check whether a screen is available.

Format code with black (bot)

4e9e1d9

sildater requested changes Sep 25, 2023

View reviewed changes

huispaty and others added 8 commits September 25, 2023 12:53

reverted performance note numbering

eb94c13

update CHANGES.md

86d2420

Changed PerformedNote object to not directly inherit from a dict but …

c7e24ce

…to perform like one. This avoids internal recursions.

Changed PerformedNote object to not directly inherit from a dict but …

b6bed0e

…to perform like one. This avoids internal recursions.

Format code with black (bot)

7b68675

Added a copy method to PerformedNote.

b838081

Merge remote-tracking branch 'origin/develop' into develop

ac42599

Added note_on_tick and note_off_tick to accepted keys.

e279f2d

sildater reviewed Sep 25, 2023

View reviewed changes

partitura/performance.py Outdated Show resolved Hide resolved

sildater reviewed Sep 25, 2023

View reviewed changes

partitura/performance.py Outdated Show resolved Hide resolved

sildater reviewed Sep 25, 2023

View reviewed changes

partitura/performance.py Show resolved Hide resolved

sildater reviewed Sep 25, 2023

View reviewed changes

partitura/performance.py Show resolved Hide resolved

manoskary and others added 5 commits September 25, 2023 17:06

Corrections on validation of PerformedNotes.

702adf7

Format code with black (bot)

2e58c9b

Added tick validation in the loop.

6151ee9

Merge remote-tracking branch 'origin/develop' into develop

f3ce4ef

# Conflicts: # partitura/performance.py

Workaround to check for screen only on linux machines to avoid missin…

fe4dbea

…g screens on servers.

sildater approved these changes Sep 25, 2023

View reviewed changes

CarlosCancino-Chacon approved these changes Sep 25, 2023

View reviewed changes

huispaty merged commit ef67b95 into main Sep 26, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR for Release 1.4.0 #320

PR for Release 1.4.0 #320

huispaty commented Sep 22, 2023 •

edited

Loading

codecov-commenter commented Sep 22, 2023 •

edited

Loading

sildater commented Sep 25, 2023

PR for Release 1.4.0 #320

PR for Release 1.4.0 #320

Conversation

huispaty commented Sep 22, 2023 • edited Loading

New Features

Bug Fixes

Other Changes

codecov-commenter commented Sep 22, 2023 • edited Loading

Codecov Report

sildater commented Sep 25, 2023

huispaty commented Sep 22, 2023 •

edited

Loading

codecov-commenter commented Sep 22, 2023 •

edited

Loading