Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure refactor match/midi/musicxml #376

Merged
merged 18 commits into from
Oct 7, 2024
Merged

Conversation

sildater
Copy link
Member

refactoring for new measure attributes for match/midi/musicxml and internal funx, both input and output

inputs:

  • import_midi: uses score.add_measures which uses both fields
  • import_match: match parses measures as noted in the match file, especially incomplete ones (see also creating a score with load_match discards measure information #246)
  • score.add_measures: consistent with the Measure class, separate handling of anacrusis measure removed
  • note_array_to_score: consistent with the Measure class

outputs:

  • export_musicxml: uses name now
  • export_match: is fine, uses its own measure format, neither name nor number
  • export_midi: is fine, uses measures only for ts changes, neither name nor number

misc:

  • type casting in import_musicxml
  • fix durations in für elise test match file

@sildater sildater linked an issue Sep 24, 2024 that may be closed by this pull request
@sildater sildater requested a review from fosfrancesco October 2, 2024 06:58
@fosfrancesco fosfrancesco merged commit d7c6008 into develop Oct 7, 2024
3 checks passed
@sildater sildater mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

creating a score with load_match discards measure information
2 participants