Stem Direction Support #392
Conversation
manoskary
commented
Oct 18, 2024
manoskary
commented
- Added support for stem direction in musicxml import/export
- Added support for stem direction export in mei export
- Added a generic note attribute called beam_direction initialized to None including minimal tests to only accept "up/down" values.
There was a problem hiding this comment.
this file is not used in the tests
There was a problem hiding this comment.
Hello @sildater. This file caused an error because since stem direction is now supported (and some were present in the original unfolded scores), it created a diff error with the unfolded variant on a different test. The same happened for all the other files you commented on below.
There was a problem hiding this comment.
this files is not used in the test
There was a problem hiding this comment.
this file is not used in the test
There was a problem hiding this comment.
the test covers a single note of one file in one function.
There was a problem hiding this comment.
Nice and simple stem encoding addition! There is probably a mistake in the original message, there is no change related to beams that I could see, only stems. Nearly all testing data changes are unused but also don't break anything, and the test is as minimal as it gets, but it's there.
