Cross staff voices #397
Merged
Cross staff voices #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion due to a musicxml conversion bug
…of musicxml, with 4 voices per staff
…n, and is able to correctly handle cross-staff voices
Merged
manoskary
requested changes
Oct 31, 2024
partitura/io/importmei.py
Outdated
| @@ -322,11 +326,9 @@ def _handle_clef(self, element, position, part): | |||
| # find the staff number | |||
| parent = element.getparent() | |||
| if parent.tag == self._ns_name("staffDef"): | |||
| # number = parent.attrib["n"] | |||
| number = 1 | |||
| number = parent.attrib["n"] | |||
There was a problem hiding this comment.
Is there a way to get the tag as a dict but in case it is not there output 1 to avoid possible key errors.
There was a problem hiding this comment.
this should never happen, but I corrected it with a default value just in case
partitura/io/importmei.py
Outdated
| @@ -982,7 +1010,7 @@ def _handle_staff_in_measure( | |||
| for i_layer, layer_el in enumerate(layers_el): | |||
| end_positions.append( | |||
| self._handle_layer_in_staff_in_measure( | |||
| layer_el, i_layer + 1, staff_ind, position, part | |||
| layer_el, int(layer_el.attrib["n"]), staff_ind, position, part | |||
There was a problem hiding this comment.
Again about the potential keyerror
There was a problem hiding this comment.
corrected with default in case of wrong or incomplete MEI
partitura/io/importmei.py
Outdated
| @@ -1063,7 +1091,7 @@ def _handle_section(self, section_el, parts, position: int, measure_number: int) | |||
| for i_s, (part, staff_el) in enumerate(zip(parts, staves_el)): | |||
| end_positions.append( | |||
| self._handle_staff_in_measure( | |||
| staff_el, i_s + 1, position, part, measure_number | |||
| staff_el, int(staff_el.attrib["n"]), position, part, measure_number | |||
There was a problem hiding this comment.
corrected with default in case of wrong or incomplete MEI
…, to avoid parsing exceptions.
|
Made some corrections following the reviewer suggestions |
manoskary
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
This pull request introduces several enhancements and bug fixes related to cross-staff voices import and handling in Partitura, specifically for MEI files which until now have been handled slightly differently than MusicXML.
Summary of changes:
- Added a file existence check in the MeiParser initialization.
- Modified MEI import to handle voices and staff numbers as specified in the score.
- Updated various methods to manage cross-staff notes.
- Enhanced the merge_parts function to support unique mappings for staff and voice numbers.
- Corrected the MEI default example.
- Updated and added new tests to reflect these changes.
manoskary
added a commit
that referenced
this pull request
Feb 27, 2025
PR for Version 1.6.0. The following changes were applied: # Updated Merge Report below the updated notes for this PR to include most recent changes ## PR for version 1.6.0 This new version addresses multiple changes, bug fixes and new features: ### New features - Measure refactor for musicxml, match, midi, note array to part in #376 - Measure feature #377 - Clef feature #382 - Clef map #384 #396 - Stem direction #392 - Support for cross staff voices in mei #397 - Improved parsing of Kern scores #413 - Fixed import for performance pedal #399 - Tick Units are now supported for pianoroll creation #412 - Scores can be loaded directly for URL #404 - Support for invisible objects in musicxml import #401 - Support for Fingering annotations in MusicXML and MEI import/export #403 ### Bug fixes - Corrected `get_time_maps_from_alignment` #360 - Corrected metrical strength features #364 - Corrected offsets for tied notes #366 - Fixed import issue #368 - Fixed Kern parsing #370 - Duration of Chord Notes #418 - Corrected symbolic note duration #372 - Fixed tuplet bug #387 - Addressed sorting for enharmonic notes #407 - Fixes eq bug on performed notes #422 - Fixed timing-tempo change bug #427 ### Other Changes - Added check for empty note array #361 - Improved documentation #362 #364 - Removed default voice estimation #373 - Added warning #379 - Removed ordering in musicxml export #391 - Improved Fingering parsing in MusicXML that could result to errors #416 - Replaced Deprecated Scipy Function #417 - Improved support for input and export in musicxml tuplet object - New option to force add new segments #410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and bug fixes related to cross-staff voices import and handling in Partitura. The modifications involve in particular the MEI import.
Changes:
_handle_note,_handle_rest,_handle_mrest,_handle_multirest, and_handle_chord,_handle_staff_in_measuremethods to handle different staff specifications for cross-staff notes and rests.autooption for reassigning staff and voice numbers, ensuring unique mappings according to MusicXML practice of 4 voices per staff.merge_partswith theautooption.