-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.6.0 #398
Open
sildater
wants to merge
156
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Version 1.6.0 #398
Changes from 1 commit
Commits
Show all changes
156 commits
Select commit
Hold shift + click to select a range
ba0266d
parse fingering info from MusicXML
CarlosCancino-Chacon e0ed514
allow to_matched_score to use note arrays as inputs
CarlosCancino-Chacon 10ad1a5
added fingering support in MEI export.
manoskary eae4542
fix 358
sildater 50d3343
add check for empty note array
sildater cbc9f48
improve documentation performance note_array
sildater d366f60
Merge pull request #360 from CPJKU/fix358
sildater 693b2c4
Format code with black (bot)
sildater 30ffdc4
Merge pull request #361 from CPJKU/fix_356
sildater 42423e0
Merge pull request #362 from CPJKU/fix_349
sildater 1e80195
fix bug, update documentation
sildater 498995e
Corrected Offsets for tied notes.
manoskary e06b975
Correction for staff line 2 as int.
manoskary 75b7213
Removed unused code and added comments.
manoskary df54d0c
Merge pull request #366 from CPJKU/kern_tied_offset_bug
sildater 9d480d9
Merge pull request #364 from CPJKU/fix_363
huispaty 8dccc0a
Format code with black (bot)
huispaty f532be4
update tutorial with correct import
sildater 26d30c5
Edits to support or remove editorials.
manoskary 0a139f2
Removed unnecessary code.
manoskary bedc78d
Naive solution for estimate_symbolic_duration
manoskary ffeb587
Update for symbolic estimation function to cover most cases from 0-4 …
manoskary 0e77947
Test for symbolic duration estimator.
manoskary d401dcb
estimate_voice_info now default to false
fosfrancesco ed0e8bb
int casting
sildater 35d56a7
update docstring load_match
sildater 699738e
remove unused match line base class imports
sildater ac9b64a
removed more unused imports
sildater 98e9086
fix typing
sildater fb64f4f
refactor bar lines
sildater bb363d8
compute bar times wip
sildater 125e1d2
barline in quarters wip
sildater b68d120
on_off_scale debug
sildater c24062f
add measures
sildater 4eafa93
cleanup
sildater 4ed8241
measure number starts at 1
sildater 7c4a695
remove anacrusis measure conditional
sildater f8120dc
note_array_to_score measure number and name
sildater 0eee6a8
measure export musicxml
sildater f69b983
reformat symbolic duration in match test file
sildater c0668c7
clean imports
sildater 13e0ced
Merge pull request #373 from CPJKU/import_lakh
sildater 5a1a6a8
Format code with black (bot)
sildater 07eb9ed
use typing tuple
sildater 5784c1c
find closest straight duration below
sildater c3e35ce
remove duplicate sym durs
sildater 7ab8b3f
set test to eighth note quintuplets
sildater e51b3e3
duration test estimation
sildater 3056e0a
file formatting
sildater 1e76b64
measure feature wip
sildater e5d8938
single measure wip
sildater de5cc0b
rework default wip
sildater 7db9f9b
fill measure info wip
sildater 4306340
measure feature complete
sildater 3fdfd39
fix time maps import
sildater 69f8945
add warning
sildater 6d24b6a
explainer in warning
sildater 9754a90
correct formatting
sildater 2d96acf
basic feature
sildater cec10ff
clef feature wip
sildater cc8c25c
clef dictionary wip
sildater 01c0ecf
clef interpolator wip
sildater 726ff82
compute note-wise clef features wip
sildater 4ae870d
numerical clef signs
sildater 788e743
add some defaults and safety
sildater ace407d
cleanup and documentation
sildater 435edc1
add safety for part without clef
sildater 9c23a9e
extrapolate
sildater c159bc9
Update globals.py
manoskary 14d2d77
fix for notes with reonset during sustain pedal on
huispaty 824a39b
Merge pull request #368 from CPJKU/fix-import348
CarlosCancino-Chacon 3520066
Merge pull request #379 from CPJKU/fix_issue_378
CarlosCancino-Chacon ca3ce79
Merge pull request #372 from CPJKU/estimate_symbolic_duration_fix
manoskary 00f6329
Format code with black (bot)
manoskary b61d8bf
updated performance features test
huispaty 91ee519
Update importkern.py
manoskary ee8dfd3
Update importkern.py
manoskary 1ca009c
Merge pull request #370 from CPJKU/kern_fixes
manoskary f424010
Format code with black (bot)
manoskary 90ae765
Add clef_map
leleogere 7d2623e
Fix a typing issue
leleogere b585213
Add a test
leleogere b2a8f5d
add test file
sildater 446340c
remove initial clefs
sildater a59cf1d
tidy test files wip
sildater 05e955b
test setup wip
sildater 340b6f9
test case extraction wip
sildater e9d3845
another try
sildater d7c6008
Merge pull request #376 from CPJKU/measure_refactor_match
fosfrancesco 1ddc259
Format code with black (bot)
fosfrancesco 682f668
Relax assertion for tuplets parsing in musicxml
manoskary 307f09d
Relax conditions for ChordSymbols by accepting empty kind.
manoskary 4c9679d
clef feature ordered by na
sildater d3947ad
articulation feature ordered
sildater 58e9b6a
ornament feature ordered
sildater acd8829
metrical feature ordered
sildater d81788c
require note ids in tests
sildater c77e5db
...
sildater b5abc4c
Added support for stem direction in musicxml import/export
manoskary c85acf9
measure feature ordered
sildater 115d3a7
measure test and data
sildater 5f265a2
add measure feature asserts
sildater 7ff737e
disable cost-based merging of non-note attributes
sildater 2a80fbc
documentation
sildater 3f88474
sign test
sildater aaaa242
all attributes
sildater b2d4106
full test unmerged
sildater 24dc6b5
full test including merging
sildater ea79e9d
support for stem direction in MEI.
manoskary 97f7930
restricted values for the support of stem direction in MEI.
manoskary fad521c
Testing musicxml import with stems.
manoskary 73a9620
adding stem information in target test files for unfolding.
manoskary 55daed4
updated the position of stem in test file.
manoskary 37cc068
Merge pull request #391 from CPJKU/fix_issue_390
sildater 187e594
Format code with black (bot)
sildater 9044296
Merge pull request #387 from CPJKU/relax_assertion_tuplet
manoskary c8d3bff
Format code with black (bot)
manoskary f0146a7
unique ID warning
sildater 36b8423
unique rest ID warning
sildater 1376edc
Merge pull request #382 from CPJKU/clef-feature
manoskary 65ec4c5
Format code with black (bot)
manoskary faa6b52
Merge pull request #384 from leleogere/add_clef_map
sildater 3bed493
refactor test
sildater 865ca57
always check for starting clef
sildater dc424fa
default to none
sildater 8cfc020
refactor clef feature
sildater 733a926
typing
sildater 8701d84
multipart and missing clef test
sildater 17a89c5
error in CI
sildater fc480bf
remove typing for CI test
sildater bf5355d
Merge pull request #396 from CPJKU/clef_map_testing
sildater 725861d
Format code with black (bot)
sildater 50c52ce
fix typo
sildater af0f1cb
remove extra lines
sildater 07225bc
Merge pull request #392 from CPJKU/stem_direction
manoskary 37811e0
Format code with black (bot)
manoskary f2a1698
update MEI example to be valid. Previous one had a wrong staff defini…
fosfrancesco c460088
adding the "auto"mode on merge_parts, which mimic the voice handling …
fosfrancesco 88fcd5a
mei import now takes voice and staff number from the score informatio…
fosfrancesco 89ce10d
updated tests
fosfrancesco 471e65f
give default values to staves and voice if they are mising in the MEI…
fosfrancesco 94b0566
Merge pull request #397 from CPJKU/cross_staff_voices
manoskary 975d300
Format code with black (bot)
manoskary 3309554
Merge pull request #377 from CPJKU/measure_feature
sildater e5bf2e1
Format code with black (bot)
sildater f72cf19
Minor doc correction for nakamura corresp.
manoskary 3f15113
Merge pull request #399 from CPJKU/performance_pedal_fix
CarlosCancino-Chacon 46895d9
Format code with black (bot)
CarlosCancino-Chacon 598af13
remove spurious musicxml file, add version
sildater 1c88e59
Merge remote-tracking branch 'origin/develop' into fingering
manoskary 86117e8
minor corrections.
manoskary 03e062b
Sort exported notes by step when same midi_pitch
leleogere f4930b5
Merge pull request #407 from leleogere/patch-1
fosfrancesco 9b82412
Format code with black (bot)
fosfrancesco bb1adac
Merge pull request #403 from CPJKU/fingering
fosfrancesco 9c31c5b
Format code with black (bot)
fosfrancesco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
measure feature ordered
- Loading branch information
commit c85acf95f566f1148926436cc6e511e01be41f79
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While all these additions of note features are great and I have no review remarks or comments about the changes I would like to raise a small concern about the
make_note_features
function which calls uponpt.score.merge_parts
to address scores with multiple parts. This approach while mostly correct it might result to some copying errors or very long computation times due to the part's recursive nature. Before merging this PR or even after, should we consider replacing the merge parts with some faster and safer np.array merging as it is done fornote_array
?