New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance pedal fix #399

Merged

CarlosCancino-Chacon merged 2 commits into develop from performance_pedal_fix

Nov 11, 2024

Collaborator

huispaty commented Nov 5, 2024

This PR includes a pedal fix for notes with reonset(s) during sustain pedal when creating performance note arrays from MIDI files.

huispaty added 2 commits

October 2, 2024 14:43


          fix for notes with reonset during sustain pedal on

14d2d77


          updated performance features test

b61d8bf

huispaty requested a review from CarlosCancino-Chacon

November 5, 2024 15:32

CarlosCancino-Chacon approved these changes

View reviewed changes

Member

CarlosCancino-Chacon commented Nov 11, 2024

This pull request provides a bug fix when adjusting the note onsets/offsets (and sound off) due to pedal changes.

It fixes the duration in ticks of the sound off (previously, only the duration in seconds was adjusted with pedal information, and the corresponding duration in ticks was not updated)
A fix for the correct adjusted note offset considering new notes (i.e., avoid overlapping notes of the same pitch)

CarlosCancino-Chacon merged commit 3f15113 into develop

3 checks passed

CarlosCancino-Chacon deleted the performance_pedal_fix branch

November 11, 2024 15:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet